git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] t5526: Fix wrong argument order in "git config"
@ 2011-01-31 16:51 Jens Lehmann
  2011-02-01 21:28 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Jens Lehmann @ 2011-01-31 16:51 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Git Mailing List, Libor Pechacek

This fixes a typo where the "git config" arguments "-f" and "--unset" were
swapped leading to the creation of a "--unset" file.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
---

Now that 1.7.4 is out and somebody else already stumbled across this
typo I introduced ...

 t/t5526-fetch-submodules.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh
index 884a5e5..a5f4585 100755
--- a/t/t5526-fetch-submodules.sh
+++ b/t/t5526-fetch-submodules.sh
@@ -124,7 +124,7 @@ test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setti
 	(
 		cd downstream &&
 		git fetch --recurse-submodules >../actual.out 2>../actual.err &&
-		git config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true &&
+		git config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules &&
 		git config --unset submodule.submodule.fetchRecurseSubmodules
 	) &&
 	test_cmp expect.out actual.out &&
-- 
1.7.3.4.27.g3921d.dirty

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] t5526: Fix wrong argument order in "git config"
  2011-01-31 16:51 [PATCH] t5526: Fix wrong argument order in "git config" Jens Lehmann
@ 2011-02-01 21:28 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2011-02-01 21:28 UTC (permalink / raw)
  To: Jens Lehmann; +Cc: Git Mailing List, Libor Pechacek

Jens Lehmann <Jens.Lehmann@web.de> writes:

> This fixes a typo where the "git config" arguments "-f" and "--unset" were
> swapped leading to the creation of a "--unset" file.
>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
> ---
>
> Now that 1.7.4 is out and somebody else already stumbled across this
> typo I introduced ...

Thanks.

>
>  t/t5526-fetch-submodules.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh
> index 884a5e5..a5f4585 100755
> --- a/t/t5526-fetch-submodules.sh
> +++ b/t/t5526-fetch-submodules.sh
> @@ -124,7 +124,7 @@ test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setti
>  	(
>  		cd downstream &&
>  		git fetch --recurse-submodules >../actual.out 2>../actual.err &&
> -		git config -f --unset .gitmodules submodule.submodule.fetchRecurseSubmodules true &&
> +		git config --unset -f .gitmodules submodule.submodule.fetchRecurseSubmodules &&
>  		git config --unset submodule.submodule.fetchRecurseSubmodules
>  	) &&
>  	test_cmp expect.out actual.out &&
> -- 
> 1.7.3.4.27.g3921d.dirty

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-01 21:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-31 16:51 [PATCH] t5526: Fix wrong argument order in "git config" Jens Lehmann
2011-02-01 21:28 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).