From: "\"Alejandro R. Sedeño\"" <asedeno@MIT.EDU>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org,
"John 'Warthog9' Hawley" <warthog9@kernel.org>,
"John 'Warthog9' Hawley" <warthog9@eaglescrag.net>
Subject: Re: [PATCH (version C) 1/2] gitweb: Prepare for splitting gitweb
Date: Wed, 02 Feb 2011 14:08:12 -0500 [thread overview]
Message-ID: <4D49AB9C.2050307@mit.edu> (raw)
In-Reply-To: <1296579016-13356-4-git-send-email-jnareb@gmail.com>
On 2/1/2011 11:50 AM, Jakub Narebski wrote:
> Prepare gitweb for being split into modules that would be installed
> in gitweblibdir, by default alongside gitweb in 'lib/' subdirectory.
>
> Gitweb would search first in 'lib/' subdirectory from where it is
> installed, via
>
> use lib __DIR__.'/lib';
>
> (This allow for tests to work with source version of gitweb without
> changes.) Then it searches in $(gitweblibdir) directory (set during
> build time), by default "$(gitwebdir)/lib", via
>
> use lib "++GITWEBLIBDIR++";
>
> "++GITWEBLIBDIR++" is set to appropriate value during build time
> (generating gitweb.cgi). This allows to select where to install
> gitweb modules via 'gitweblibdir' build time configuration variable
I would personally prefer to see this path taken, as it seems the most
flexible and would fulfill a use case I have.
I maintain a build of git in an AFS volume at MIT. One of its uses is
symlinking to the current gitweb.cgi to instantly deploy a gitweb in a
shared hosting environment (example: http://git.scripts.mit.edu/).
__DIR__ would point to the directory containing a user symlink to
gitweb, which would allow users to add their own libraries, while
++GITWEBLIBDIR++ would allow the standard gitweb libraries to be hosted
at a common path without placing additional burdens on the user at
upgrade time.
-Alejandro
next prev parent reply other threads:[~2011-02-02 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 16:50 [PATCH 0/2] gitweb: Begin splitting gitweb Jakub Narebski
2011-02-01 16:50 ` [PATCH (version A) 1/2] gitweb: Prepare for " Jakub Narebski
2011-02-01 16:50 ` [PATCH (version B) " Jakub Narebski
2011-02-01 16:50 ` [PATCH (version C) " Jakub Narebski
2011-02-02 19:08 ` "Alejandro R. Sedeño" [this message]
2011-02-11 23:21 ` Jakub Narebski
2011-02-01 16:50 ` [PATCH (proof of concept) 2/2] gitweb: Create Gitweb::Util module Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D49AB9C.2050307@mit.edu \
--to=asedeno@mit.edu \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=warthog9@eaglescrag.net \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).