From: Vampire <Vampire@Masters-of-Disaster.de>
To: git@vger.kernel.org
Subject: Bug in "git diff-files"
Date: Thu, 10 Feb 2011 18:56:07 +0100 [thread overview]
Message-ID: <4D5426B7.9010007@Masters-of-Disaster.de> (raw)
Hi,
I found a bug in git diff-files.
git diff-files with a --diff-filter and --quiet given behaves bad.
I have a diff-filter of U and one file M and one U.
But diff-lib.c:105-107 in commit 1a9fe45 stops as soon as HAS_CHANGES is
true.
In my case it found the M file and stops searching as --quiet is given.
But then when applying the diff-filter, this M instance is filtered out
and thus 0 is returned instead of 1 which is returned with --exit-code
and without --quiet.
Regards
Björn Kautler
reply other threads:[~2011-02-10 17:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5426B7.9010007@Masters-of-Disaster.de \
--to=vampire@masters-of-disaster.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).