From: Michael J Gruber <git@drmicha.warpmail.net>
To: Lars Noschinski <lars@public.noschinski.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: grep --no-index and pathspec
Date: Fri, 11 Feb 2011 16:04:43 +0100 [thread overview]
Message-ID: <4D55500B.1070603@drmicha.warpmail.net> (raw)
In-Reply-To: <20110211095938.360726y1zinab9gk@webmail.df.eu>
Lars Noschinski venit, vidit, dixit 11.02.2011 09:59:
> Hi everyone,
>
> I encountered some strange behaviour with grep when using both the
> --no-index option and a pathspec. Glob patterns seem to be ignored:
>
> ----------
> $ git grep -l --no-index . -- '*.bib'
> paper.bib
> paper.tex
> ex1.tex
> ----------
>
> But on the other hands, leading path matches work:
> ----------
> $ git grep -l --no-index . -- 'paper'
> paper.bib
> paper.tex
> ----------
>
> Without the --no-index option, everything works fine:
> ----------
> $ git grep -l --no-index . -- '*.bib'
> paper.bib
> ----------
>
> This is with git version 1.7.4, but I encountered it also with the
> 1.7.2.3 Debian package.
"grep --no-index" and "grep" have different codepaths for looking up the
files/blobs. If I read that correctly then "grep --no-index -- pathspec"
only does a literal match at the left boundary, whereas for the normal
mode glob patterns are allowed.
CC'ing Junio who created "--no-index".
Michael
next prev parent reply other threads:[~2011-02-11 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 8:59 grep --no-index and pathspec Lars Noschinski
2011-02-11 15:04 ` Michael J Gruber [this message]
2011-02-11 15:06 ` [PATCH] grep.txt: document pathspec for --no-index Michael J Gruber
2011-02-11 18:27 ` grep --no-index and pathspec Junio C Hamano
2011-02-11 21:37 ` Junio C Hamano
2011-02-12 8:14 ` Nguyen Thai Ngoc Duy
2011-02-12 8:26 ` Junio C Hamano
2011-02-12 8:39 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D55500B.1070603@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lars@public.noschinski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).