From: Rafael Kitover <rkitover@io.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] fixes for ActiveState Perl
Date: Mon, 14 Feb 2011 14:39:09 -0500 [thread overview]
Message-ID: <4D5984DD.1030004@io.com> (raw)
In-Reply-To: <AANLkTimCXEbzZnR1k32u942hjB37nThN_RDBL5N7owHa@mail.gmail.com>
On 2/14/2011 7:49 AM, Erik Faye-Lund wrote:
...
>> diff --git a/perl/Makefile b/perl/Makefile
>> index a2ffb64..1fa99cd 100644
>> --- a/perl/Makefile
>> +++ b/perl/Makefile
>> @@ -3,18 +3,28 @@
>> #
>> makfile:=perl.mak
>>
>> +# support PERL_PATH=C:\\Perl\\bin\\perl
>> +PERL_PATH := $(subst \,\\,$(PERL_PATH))
>> +
>> PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH))
>> +PERL_MAKE := MAKEFLAGS="" $(subst \,\\,$(shell $(subst \,\\,$(PERL_PATH)) -MConfig -le "print ((\%Config)->{make})"))
>> +
>> +ifneq (,$(findstring nmake,$(PERL_MAKE)))
>> + PERL_MAKE := $(PERL_MAKE) -nologo
>> +endif
>> +
>> prefix_SQ = $(subst ','\'',$(prefix))
>>
>> ifndef V
>> QUIET = @
>> endif
>>
>> +
>
> Why?
Windows perl (activestate, strawberry) uses nmake or dmake. The
makefiles for these makes are incompatible with GNU make. This code
retrieves the make Perl would use from its Config, and uses that on
invoking perl.mak .
This should also allow for using EU::MM for the MSVC+ActiveState build.
next prev parent reply other threads:[~2011-02-14 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 11:40 [PATCH] fixes for ActiveState Perl Rafael Kitover
2011-02-14 12:49 ` Erik Faye-Lund
2011-02-14 19:39 ` Rafael Kitover [this message]
2011-02-14 19:48 ` Erik Faye-Lund
2011-02-15 11:49 ` Rafael Kitover
2011-02-17 14:07 ` Rafael Kitover
2011-02-20 11:58 ` Sverre Rabbelier
2011-02-23 0:59 ` Rafael Kitover
2011-02-14 15:26 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5984DD.1030004@io.com \
--to=rkitover@io.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).