From: Nick <oinksocket@letterboxes.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jakub Narebski" <jnareb@gmail.com>,
git@vger.kernel.org, "Petr Baudis" <pasky@suse.cz>,
"Alex Riesen" <raa.lkml@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [1.8.0] perl/Git.pm: moving away from using Error.pm module
Date: Mon, 21 Feb 2011 11:02:10 +0000 [thread overview]
Message-ID: <4D624632.80904@letterboxes.org> (raw)
In-Reply-To: <7v4o7xluph.fsf@alter.siamese.dyndns.org>
On 21/02/11 07:20, Junio C Hamano wrote:
> If we are going to change things so that everybody uses a
> more traditional "eval {}; if ($@) { ... }", it would be a welcome change
> from my point of view.
A small aside - note the "Dangers of using $@" described here:
http://www.socialtext.net/perl5/exception_handling
To paraphrase, this:
eval { stuff ; 1} or do { handle_exception };
is marginally safer than:
eval { stuff }; if (defined $@) { handle_exception }
because it is possible that $@ can be modified (say, by a DESTROY method) before
the if clause sees it. The former idiom does not stop that, it just means your
exception handler is executed reliably.
Normally it is not a problem, but this is still something worth knowing.
N
next prev parent reply other threads:[~2011-02-21 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 22:46 [1.8.0] perl/Git.pm: moving away from using Error.pm module Jakub Narebski
2011-02-21 7:20 ` Junio C Hamano
2011-02-21 9:31 ` Jakub Narebski
2011-02-21 11:02 ` Nick [this message]
2011-02-21 12:12 ` Jakub Narebski
2011-02-21 12:31 ` Ævar Arnfjörð Bjarmason
2011-04-15 23:35 ` Avner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D624632.80904@letterboxes.org \
--to=oinksocket@letterboxes.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).