From: Guy Rouillier <guyr@burntmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Martin Langhoff <martin@laptop.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Emil Medve <Emilian.Medve@freescale.com>,
git <git@vger.kernel.org>, Pascal Obry <pascal@obry.net>,
Clemens Buchacher <drizzd@aon.at>
Subject: Re: cvsimport still not working with cvsnt
Date: Tue, 22 Feb 2011 21:33:12 -0500 [thread overview]
Message-ID: <4D6471E8.4060001@burntmail.com> (raw)
In-Reply-To: <7vaahnbmu2.fsf@alter.siamese.dyndns.org>
On 2/22/2011 7:45 PM, Junio C Hamano wrote:
> Guy Rouillier<guyr@burntmail.com> writes:
>
>> To answer Junio's question, I'm looking at the CVSNT code now
>> (GlobalSettings.cpp, if anyone is interested.) The password is stored
>> in a general fashion like any other user-specified value. So, the
>> authors elected to use a properties file format of key=value. That is
>> as valid a format as any other.
>
> As you dug that far, could you find out what happens when cvsroot contains
> an equal-sign character in its path component?
>
> I am starting to suspect that we do need two separate codepaths, and we
> would need to split out the logic to find matching password entry given a
> cvsroot value into a separate function to keep our sanity after all.
>
I'll take a look. I spent a short amount of time with Google looking
for "cvsroot valid characters" but didn't find anything authoritative.
Note that this issue is not unique to CVSNT. What does CVS do with
CVSROOT containing a space character?
--
Guy Rouillier
next prev parent reply other threads:[~2011-02-23 2:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 4:05 cvsimport still not working with cvsnt Guy Rouillier
2010-12-20 21:36 ` Jonathan Nieder
2010-12-21 22:09 ` Emil Medve
2010-12-22 5:43 ` Guy Rouillier
2011-01-10 7:33 ` Guy Rouillier
2011-01-10 15:38 ` Martin Langhoff
2011-01-14 6:38 ` Guy Rouillier
2011-01-14 7:44 ` Jonathan Nieder
2011-01-14 21:49 ` Junio C Hamano
2011-01-30 6:33 ` Guy Rouillier
2011-01-30 20:19 ` Martin Langhoff
2011-02-10 22:01 ` Junio C Hamano
2011-02-18 6:26 ` Guy Rouillier
2011-02-18 18:34 ` Junio C Hamano
2011-02-19 7:17 ` Guy Rouillier
2011-02-20 7:21 ` Junio C Hamano
2011-02-21 4:30 ` Guy Rouillier
2011-02-21 23:33 ` Junio C Hamano
2011-02-22 23:08 ` Junio C Hamano
2011-02-22 23:50 ` Martin Langhoff
2011-02-23 0:08 ` Guy Rouillier
2011-02-23 0:45 ` Junio C Hamano
2011-02-23 2:33 ` Guy Rouillier [this message]
2011-02-23 5:24 ` Junio C Hamano
2011-02-27 5:20 ` Guy Rouillier
2011-02-27 8:26 ` Junio C Hamano
2011-04-29 4:27 ` Guy Rouillier
2011-04-29 22:27 ` Jonathan Nieder
2011-05-01 5:33 ` Guy Rouillier
2011-05-01 18:44 ` Junio C Hamano
2011-02-23 0:42 ` Junio C Hamano
2011-02-24 3:14 ` Guy Rouillier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6471E8.4060001@burntmail.com \
--to=guyr@burntmail.com \
--cc=Emilian.Medve@freescale.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=martin@laptop.org \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).