* [PATCH] object.h: Remove obsolete struct object_refs
@ 2011-03-14 16:23 Jakob Pfender
2011-03-14 17:03 ` Michael J Gruber
2011-03-14 17:48 ` Junio C Hamano
0 siblings, 2 replies; 3+ messages in thread
From: Jakob Pfender @ 2011-03-14 16:23 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano
The struct object_refs in object.h is never used anywhere, so remove it.
Signed-off-by: Jakob Pfender <jpfender@elegosoft.com>
---
object.h | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/object.h b/object.h
index 4d1d615..b6618d9 100644
--- a/object.h
+++ b/object.h
@@ -6,11 +6,6 @@ struct object_list {
struct object_list *next;
};
-struct object_refs {
- unsigned count;
- struct object *ref[FLEX_ARRAY]; /* more */
-};
-
struct object_array {
unsigned int nr;
unsigned int alloc;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] object.h: Remove obsolete struct object_refs
2011-03-14 16:23 [PATCH] object.h: Remove obsolete struct object_refs Jakob Pfender
@ 2011-03-14 17:03 ` Michael J Gruber
2011-03-14 17:48 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Michael J Gruber @ 2011-03-14 17:03 UTC (permalink / raw)
To: Jakob Pfender; +Cc: git, Junio C Hamano
Jakob Pfender venit, vidit, dixit 14.03.2011 17:23:
> The struct object_refs in object.h is never used anywhere, so remove it.
>
Maybe you could add the information that it is unused since
7914053 (Remove unused object-ref code, 2008-02-25)
That saves everyone else a pickaxe :)
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] object.h: Remove obsolete struct object_refs
2011-03-14 16:23 [PATCH] object.h: Remove obsolete struct object_refs Jakob Pfender
2011-03-14 17:03 ` Michael J Gruber
@ 2011-03-14 17:48 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2011-03-14 17:48 UTC (permalink / raw)
To: Jakob Pfender; +Cc: git
Jakob Pfender <jpfender@elegosoft.com> writes:
> The struct object_refs in object.h is never used anywhere, so remove it.
>
> Signed-off-by: Jakob Pfender <jpfender@elegosoft.com>
Thanks; I'd rephrase the above like this (no need to resend):
7914053 (Remove unused object-ref code, 2008-02-25) removed
all uses of the structure from the code, but forgot to remove
the type definition itself.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-14 17:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-14 16:23 [PATCH] object.h: Remove obsolete struct object_refs Jakob Pfender
2011-03-14 17:03 ` Michael J Gruber
2011-03-14 17:48 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).