* [PATCH] Documentation: running test with --debug keeps "trash" directory
@ 2011-03-14 19:50 Piotr Krukowiecki
2011-03-14 21:32 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Piotr Krukowiecki @ 2011-03-14 19:50 UTC (permalink / raw)
To: git, Junio C Hamano
Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
---
t/README | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
It wasn't documented and I didn't notice it at first and found
it out only after I've started implementing --keep-trash option.
diff --git a/t/README b/t/README
index 78c9e65..5db567e 100644
--- a/t/README
+++ b/t/README
@@ -79,6 +79,9 @@ appropriately before running "make".
--debug::
This may help the person who is developing a new test.
It causes the command defined with test_debug to run.
+ The "trash" directory (used to store all temporary data
+ during testing) is not deleted even if there are no
+ failed tests.
--immediate::
This causes the test to immediately exit upon the first
--
1.7.4.1.228.g9e388
--
Piotr Krukowiecki
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: running test with --debug keeps "trash" directory
2011-03-14 19:50 [PATCH] Documentation: running test with --debug keeps "trash" directory Piotr Krukowiecki
@ 2011-03-14 21:32 ` Junio C Hamano
2011-03-15 19:58 ` Piotr Krukowiecki
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2011-03-14 21:32 UTC (permalink / raw)
To: Piotr Krukowiecki; +Cc: git, Junio C Hamano
Piotr Krukowiecki <piotr.krukowiecki@gmail.com> writes:
> Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
> ---
> t/README | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> It wasn't documented and I didn't notice it at first and found
> it out only after I've started implementing --keep-trash option.
>
> diff --git a/t/README b/t/README
> index 78c9e65..5db567e 100644
> --- a/t/README
> +++ b/t/README
> @@ -79,6 +79,9 @@ appropriately before running "make".
> --debug::
> This may help the person who is developing a new test.
> It causes the command defined with test_debug to run.
> + The "trash" directory (used to store all temporary data
> + during testing) is not deleted even if there are no
> + failed tests.
missing is "...so that you can inspect its contents after the test
finished." at the end.
> --immediate::
> This causes the test to immediately exit upon the first
> --
> 1.7.4.1.228.g9e388
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: running test with --debug keeps "trash" directory
2011-03-14 21:32 ` Junio C Hamano
@ 2011-03-15 19:58 ` Piotr Krukowiecki
0 siblings, 0 replies; 3+ messages in thread
From: Piotr Krukowiecki @ 2011-03-15 19:58 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
W dniu 14.03.2011 22:32, Junio C Hamano pisze:
> Piotr Krukowiecki <piotr.krukowiecki@gmail.com> writes:
>
>> Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
>> ---
>> t/README | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> It wasn't documented and I didn't notice it at first and found
>> it out only after I've started implementing --keep-trash option.
>>
>> diff --git a/t/README b/t/README
>> index 78c9e65..5db567e 100644
>> --- a/t/README
>> +++ b/t/README
>> @@ -79,6 +79,9 @@ appropriately before running "make".
>> --debug::
>> This may help the person who is developing a new test.
>> It causes the command defined with test_debug to run.
>> + The "trash" directory (used to store all temporary data
>> + during testing) is not deleted even if there are no
>> + failed tests.
>
> missing is "...so that you can inspect its contents after the test
> finished." at the end.
If you think it's needed here's a patch.
I'm not sure - maybe it should be "after the test finishe_s_"? I'm not
native English speaker though...
---8<---
From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
Date: Mon, 14 Mar 2011 18:50:47 +0100
Subject: [PATCH] Documentation: running test with --debug keeps "trash" directory
Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
---
t/README | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/t/README b/t/README
index 78c9e65..165e7cf 100644
--- a/t/README
+++ b/t/README
@@ -79,6 +79,10 @@ appropriately before running "make".
--debug::
This may help the person who is developing a new test.
It causes the command defined with test_debug to run.
+ The "trash" directory (used to store all temporary data
+ during testing) is not deleted even if there are no
+ failed tests so that you can inspect its contents after
+ the test finished.
--immediate::
This causes the test to immediately exit upon the first
--
1.7.4.1.228.g9e388
--
Piotr Krukowiecki
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-15 19:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-14 19:50 [PATCH] Documentation: running test with --debug keeps "trash" directory Piotr Krukowiecki
2011-03-14 21:32 ` Junio C Hamano
2011-03-15 19:58 ` Piotr Krukowiecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).