From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: running test with --debug keeps "trash" directory
Date: Tue, 15 Mar 2011 20:58:14 +0100 [thread overview]
Message-ID: <4D7FC4D6.9010100@gmail.com> (raw)
In-Reply-To: <7vy64hbd6c.fsf@alter.siamese.dyndns.org>
W dniu 14.03.2011 22:32, Junio C Hamano pisze:
> Piotr Krukowiecki <piotr.krukowiecki@gmail.com> writes:
>
>> Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
>> ---
>> t/README | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> It wasn't documented and I didn't notice it at first and found
>> it out only after I've started implementing --keep-trash option.
>>
>> diff --git a/t/README b/t/README
>> index 78c9e65..5db567e 100644
>> --- a/t/README
>> +++ b/t/README
>> @@ -79,6 +79,9 @@ appropriately before running "make".
>> --debug::
>> This may help the person who is developing a new test.
>> It causes the command defined with test_debug to run.
>> + The "trash" directory (used to store all temporary data
>> + during testing) is not deleted even if there are no
>> + failed tests.
>
> missing is "...so that you can inspect its contents after the test
> finished." at the end.
If you think it's needed here's a patch.
I'm not sure - maybe it should be "after the test finishe_s_"? I'm not
native English speaker though...
---8<---
From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
Date: Mon, 14 Mar 2011 18:50:47 +0100
Subject: [PATCH] Documentation: running test with --debug keeps "trash" directory
Signed-off-by: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
---
t/README | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/t/README b/t/README
index 78c9e65..165e7cf 100644
--- a/t/README
+++ b/t/README
@@ -79,6 +79,10 @@ appropriately before running "make".
--debug::
This may help the person who is developing a new test.
It causes the command defined with test_debug to run.
+ The "trash" directory (used to store all temporary data
+ during testing) is not deleted even if there are no
+ failed tests so that you can inspect its contents after
+ the test finished.
--immediate::
This causes the test to immediately exit upon the first
--
1.7.4.1.228.g9e388
--
Piotr Krukowiecki
prev parent reply other threads:[~2011-03-15 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 19:50 [PATCH] Documentation: running test with --debug keeps "trash" directory Piotr Krukowiecki
2011-03-14 21:32 ` Junio C Hamano
2011-03-15 19:58 ` Piotr Krukowiecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7FC4D6.9010100@gmail.com \
--to=piotr.krukowiecki@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).