From: Johannes Sixt <j.sixt@viscovery.net>
To: Stephen Boyd <bebarino@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] Fix sparse warnings
Date: Mon, 21 Mar 2011 11:10:40 +0100 [thread overview]
Message-ID: <4D872420.8080501@viscovery.net> (raw)
In-Reply-To: <1300700704-22674-2-git-send-email-bebarino@gmail.com>
Am 3/21/2011 10:45, schrieb Stephen Boyd:
> diff --git a/daemon.c b/daemon.c
> index 347fd0c..4c8346d 100644
> --- a/daemon.c
> +++ b/daemon.c
> @@ -660,7 +660,7 @@ static void check_dead_children(void)
> static char **cld_argv;
> static void handle(int incoming, struct sockaddr *addr, socklen_t addrlen)
> {
> - struct child_process cld = { 0 };
> + struct child_process cld = { NULL };
IMO this change is not good.
The purpose of { 0} is not to initialize (only) the first member, but
rather to serve as a visual marker that says "We want the complete struct
zero-initialized".
> diff --git a/fast-import.c b/fast-import.c
> index d9f9a3f..65d65bf 100644
> --- a/fast-import.c
> +++ b/fast-import.c
> @@ -2939,7 +2939,7 @@ static void parse_ls(struct branch *b)
> {
> const char *p;
> struct tree_entry *root = NULL;
> - struct tree_entry leaf = {0};
> + struct tree_entry leaf = {NULL};
Same here.
> diff --git a/imap-send.c b/imap-send.c
> index 71506a8..9adf4b9 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1069,7 +1069,7 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
>
> if (srvc->tunnel) {
> const char *argv[] = { srvc->tunnel, NULL };
> - struct child_process tunnel = {0};
> + struct child_process tunnel = {NULL};
And here.
> diff --git a/transport.c b/transport.c
> index 0078660..f1c0781 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -192,7 +192,7 @@ static const char *rsync_url(const char *url)
> static struct ref *get_refs_via_rsync(struct transport *transport, int for_push)
> {
> struct strbuf buf = STRBUF_INIT, temp_dir = STRBUF_INIT;
> - struct ref dummy = {0}, *tail = &dummy;
> + struct ref dummy = {NULL}, *tail = &dummy;
And here.
-- Hannes
next prev parent reply other threads:[~2011-03-21 10:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 9:45 [PATCH 1/2] Makefile: Cover more files with make check Stephen Boyd
2011-03-21 9:45 ` [PATCH 2/2] Fix sparse warnings Stephen Boyd
2011-03-21 10:10 ` Johannes Sixt [this message]
2011-03-21 10:12 ` Stephen Boyd
2011-03-21 16:12 ` Junio C Hamano
2011-03-21 16:15 ` Junio C Hamano
2011-03-21 18:01 ` [PATCHv2 " Stephen Boyd
2011-03-21 19:29 ` Junio C Hamano
2011-03-21 21:58 ` Junio C Hamano
2011-03-21 22:04 ` Stephen Boyd
2011-03-22 7:51 ` [PATCHv3 " Stephen Boyd
2011-03-22 17:18 ` Junio C Hamano
2011-03-21 17:27 ` [PATCH 1/2] Makefile: Cover more files with make check Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D872420.8080501@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).