From: Jens Lehmann <Jens.Lehmann@web.de>
To: devel-git@morey-chaisemartin.com
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-submodule: Remove duplicate entries during merge with conflict
Date: Mon, 21 Mar 2011 21:53:27 +0100 [thread overview]
Message-ID: <4D87BAC7.4010505@web.de> (raw)
In-Reply-To: <4D870FAB.4050307@morey-chaisemartin.com>
Am 21.03.2011 09:43, schrieb Nicolas Morey-Chaisemartin:
> I agree that the actual behavior of status is definitely wrong and it should be changed.
Yup.
> But I think there needs to be a simple way for a user to know whats happening to a conflicted submodule.
> When merging a file, editing the conflicting area in the code is often enough.
> For a submodule, I think the user needs an easy access to which branch used what SHA1.
You can see the sha1s using "git diff":
diff --cc submod
index bd4cfe7,7128fbd..0000000
--- a/submod
+++ b/submod
(But the sha1s don't tell you much about what differing commits you
have in the submodule branches, which would be really helpful for
deciding how to solve the merge conflict. Unfortunately "git diff
--submodule" doesn't work for merge conflicts yet, another issue on
my ToDo-list ...)
> Git submodule status is probably not the right place to do that.
I agree.
> git ls-files --stage allows that but it's not part of the standard porcelain commands...
And it shows you three sha1s, one of them being the current state of
the submodule. Me thinks the output of "git diff" is easier to digest.
> I'll check/test the patch you proposed as soon as possible and repost it if it's allright !
Cool!
next prev parent reply other threads:[~2011-03-21 20:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 8:09 [PATCH] git-submodule: Remove duplicate entries during merge with conflict Nicolas Morey-Chaisemartin
2011-03-17 18:47 ` Junio C Hamano
2011-03-17 20:50 ` Junio C Hamano
2011-03-21 8:43 ` Nicolas Morey-Chaisemartin
2011-03-21 20:53 ` Jens Lehmann [this message]
2011-03-21 20:29 ` Jens Lehmann
2011-03-21 20:59 ` Junio C Hamano
2011-03-21 21:34 ` Nicolas Morey-Chaisemartin
2011-03-21 22:01 ` Jens Lehmann
2011-03-22 6:28 ` Nicolas Morey-Chaisemartin
2011-07-14 18:33 ` funeeldy
2011-07-15 19:27 ` Jens Lehmann
2011-07-15 20:32 ` Marlene Cote
2011-07-15 21:41 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D87BAC7.4010505@web.de \
--to=jens.lehmann@web.de \
--cc=devel-git@morey-chaisemartin.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).