git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: git@vger.kernel.org
Subject: "git svn mkdirs" is very slow
Date: Mon, 28 Mar 2011 17:05:14 +0200	[thread overview]
Message-ID: <4D90A3AA.3050601@alum.mit.edu> (raw)

Hello,

I've noticed that in our repository, "git svn mkdirs" or any other
command that calls mkemptydirs() is very slow (approximately 8.5 s even
with a warm disk cache).  Presumably this is related to the fact that
the unhandled.log.gz for our Subversion trunk is almost 10 Mb.

Of course it would be nice if this were faster.

But we have laid out our repository to make the presence/absence of
empty directories irrelevant, so we would be just as happy if git-svn
would *not* create empty directories, like in the good old days.  So I
wanted to implement the following feature:

1. An svn.autoMkdirs / svn-remote.<name>.autoMkdirs configuration
variable.  The value should default to true for backwards compatibility.

2. Only call mkemptydirs() if this variable is set to true.

3. Make an exception for "git svn mkdirs", which should do its thing
regardless of how this configuration option is set.

I think it should only be about a 10-line change, plus documentation and
tests.  Unfortunately, my perl-foo is very limited, and it will take me
a while to figure out how option parsing and handling works in git-svn.

Would this feature be welcome?

Is there anybody willing to make the Perl changes?  I would be willing
to work on the documentation and test suite changes.

Thanks,
Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/

             reply	other threads:[~2011-03-28 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28 15:05 Michael Haggerty [this message]
2011-03-28 17:44 ` "git svn mkdirs" is very slow Junio C Hamano
2011-04-01 10:26   ` [PATCH] git-svn: add an option to skip the creation of empty directories Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D90A3AA.3050601@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).