From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: git@vger.kernel.org
Subject: RFC: git send-email and error handling
Date: Thu, 14 Apr 2011 16:10:12 -0400 [thread overview]
Message-ID: <4DA754A4.3090709@windriver.com> (raw)
I came across a situation today where the behaviour of git send-email
kind of surprised me -- in that it seemed definitely less than ideal
for the use case I had.
For stable linux kernel releases, it is very common to send
hundreds of patches at once, to people you've never contacted before,
simply because the are called out in CC: or SOB: lines of a patch
that has been cherry picked. So it is highly likely that you may
hit full inboxes, expired accounts and so on.
The command line (git 1.7.4.4) is typically something like:
git send-email --to stable@kernel.org --to linux-kernel@vger.kernel.org \
--cc stable-review@kernel.org some_patch_dir
So, let me get to what happened today: After sending 113 out of 209
patches, it came to the 114th patch, and gave me this:
(mbox) Adding cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> from line 'From: Dmitry Torokhov <dmitry.torokhov@gmail.com>'
(body) Adding cc: Dmitry Torokhov <dtor@mail.ru> from line 'Signed-off-by: Dmitry Torokhov <dtor@mail.ru>'
(body) Adding cc: Paul Gortmaker <paul.gortmaker@windriver.com> from line 'Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>'
5.2.1 <dtor@mail.ru>... Mailbox disabled for this recipient
Then, taking that as a hard error, it simply exited,
leaving me scrambling to figure out how to quickly fix the
offending patch and continue with the unsent queue.
From my point of view, the right thing to do here would have
been to ignore the error on the harvested mail address, and continue
on through the rest of the queue. Or even interactively ask me what
to do when it saw the 5.2.1 failure. But maybe that wouldn't be
right for everyone. I didn't see anything in the GSE man page
that would let me configure this behaviour either.
Anyway, I thought I'd mention it and see where the discussion went.
Thanks,
Paul.
next reply other threads:[~2011-04-14 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 20:10 Paul Gortmaker [this message]
2011-04-14 21:09 ` RFC: git send-email and error handling Jeff King
2011-04-15 0:30 ` Paul Gortmaker
2011-04-15 3:42 ` Jeff King
2011-05-04 16:12 ` [RFC/PATCH] git-send-email: Remember sources of Cc addresses Jakub Narebski
2011-05-04 21:35 ` Jeff King
2011-05-05 14:01 ` [RFC/PATCH 2/2] git-send-email: Do not require that addresses added from body be valid Jakub Narebski
2011-05-06 11:22 ` [RFC/PATCH 3/2 (squash!)] git-send-email: Warn about rejected automatically added recipients Jakub Narebski
2011-05-07 13:21 ` [RFC/PATCH 2/2] git-send-email: Do not require that addresses added from body be valid Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA754A4.3090709@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).