git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Hord <hordp@cisco.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Michael O'Cleirigh" <michael.ocleirigh@rivulet.ca>,
	Johannes Sixt <j6t@kdbg.org>,
	git@vger.kernel.org
Subject: Re: [PATCH] git-filter-branch: add --egrep-filter option
Date: Tue, 19 Apr 2011 12:03:13 -0400	[thread overview]
Message-ID: <4DADB241.1060602@cisco.com> (raw)
In-Reply-To: <20110419080143.GA17915@elie>



On 04/19/2011 04:01 AM, Jonathan Nieder wrote:
> Hi,
>
> Michael O'Cleirigh wrote:
>
>> After considering your comment I have to agree with you that it is a
>> special case of index-filter and probably not useful/general for
>> enough other cases to justify adding in a new command line option.
> Now, why do you give up so easily? ;-)
>
> Surely what your patch is hinting at is the possibility of an
> --ls-tree-filter (for lack of a better name) that works with trees
> without the overhead of unpacking them.

I have invented something similar[*] for git three different times in
three different ways.  The last one is the fastest and uses
git-fast-import instead of filter-branch, but I was sure one of the
filter-branch methods would have been more efficient.  More examples
would be very welcome.

Phil

[*] My implementations mostly focused on applying a ".gitignore" file to
the repo history.  I spent many hours on this.  I wound up with a script
that also handles file and branch renaming (the latter important so I
can run different filters on the same repo and drop results into
different branches).  It's not patch-worthy (yet), but I would have
loved to have more examples along the way such as the mktree one you
just provided.

      reply	other threads:[~2011-04-19 16:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 22:50 [PATCH] git-filter-branch: add --egrep-filter option Michael O'Cleirigh
2011-04-16  8:16 ` Johannes Sixt
2011-04-17  1:45   ` Michael O'Cleirigh
2011-04-19  8:01     ` Jonathan Nieder
2011-04-19 16:03       ` Phil Hord [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DADB241.1060602@cisco.com \
    --to=hordp@cisco.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=jrnieder@gmail.com \
    --cc=michael.ocleirigh@rivulet.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).