From: Marius Storm-Olsen <mstormo@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Marius Storm-Olsen <marius@storm-olsen.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: [PATCH] Refactor git-completion to allow ZSH usage of PS1 functions
Date: Tue, 26 Apr 2011 12:37:42 -0500 [thread overview]
Message-ID: <4DB702E6.5090105@gmail.com> (raw)
In-Reply-To: <7v62q1exnj.fsf@alter.siamese.dyndns.org>
Junio C Hamano said the following on 26.04.2011 12:21:
> I'd be very negative on splitting this file into more than one files.
The only other option would be duplication. Is that preferred?
I was hoping to more easily keep the implementations in sync, given
that the code is trivial enough for both shells to interpret. However,
having two separate implementations would allow for more advanced
options in the ZSH PSx handling, I guess.
--
.marius
next prev parent reply other threads:[~2011-04-26 17:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 13:24 [PATCH] Refactor git-completion to allow ZSH usage of PS1 functions Marius Storm-Olsen
2011-04-26 17:21 ` Junio C Hamano
2011-04-26 17:37 ` Marius Storm-Olsen [this message]
2011-04-26 19:15 ` Junio C Hamano
2011-04-26 20:28 ` [PATCH] Automatically autoload bashcompinit for ZSH, when needed Marius Storm-Olsen
2011-04-26 20:47 ` Matthieu Moy
2011-04-26 20:52 ` Marius Storm-Olsen
2011-04-26 21:55 ` Junio C Hamano
2011-04-27 1:11 ` Felipe Contreras
2011-04-27 1:22 ` Felipe Contreras
2011-04-27 3:23 ` [PATCH v2] " Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB702E6.5090105@gmail.com \
--to=mstormo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marius@storm-olsen.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).