From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kacper Kornet <kornet@camk.edu.pl>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir
Date: Wed, 04 May 2011 07:52:30 +0200 [thread overview]
Message-ID: <4DC0E99E.6090402@viscovery.net> (raw)
In-Reply-To: <7vzkn3itb5.fsf@alter.siamese.dyndns.org>
Am 5/3/2011 19:32, schrieb Junio C Hamano:
> Johannes Sixt <j.sixt@viscovery.net> writes:
>
>> Please do not set Mail-Followup-To!! It makes communication on this list
>> extremely inconvenient.
>>
>> Am 4/28/2011 21:27, schrieb Kacper Kornet:
>>> Definitions of ETC_GITCONFIG, ETC_GITATTRIBUTES and sysconfdir depend on
>>> value of prefix. As prefix can be changed in config.mak.autogen, all if
>>> blocks with conditions based on prefix should be placed after the file
>>> is included in Makefile.
>> ...
>> Does this patch do anything useful? After the patch is applied, sysconfdir
>> is set-but-not-used. Therefore, you can remove the assignments. But then
>> you lose the reference to $(prefix) that the commit message claims is so
>> important. Puzzled...
>
> The only thing it does is to to allow you to set prefix in config.mak and
> then have it propaget to the selection of ETC_GITCONFIG (if prefix is /usr,
> then it is always /etc/gitconfig, otherwise it is always etc/gitconfig).
> The importance of prefix is not that the value is prefixed to ETC_GIT*,
> but it is used in the conditional to choose between the two.
Fair enough.
> We can get rid of assignments to sysconfdir in that sense. But you spotted
> a regression. If sysconfdir is set to somewhere else, even if you set prefix
> to /usr, we should set ETC_GIT* using the value given to sysconfdir. The
> original code did so, but the patch lost it.
Looking closer, the patch introduces git_etcdir for no good reason, IIUC.
It should just re-use sysconfdir (the meaning of this variable is to point
to the etc directory).
-- Hannes
next prev parent reply other threads:[~2011-05-04 5:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 2:29 [PATCH] Respect definition of prefix from autotools in ETC_GITCONFIG and ETC_GITATTRIBUTES Kacper Kornet
2011-04-28 16:54 ` Junio C Hamano
2011-04-28 17:49 ` Kacper Kornet
2011-04-28 19:27 ` [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir Kacper Kornet
2011-04-28 20:01 ` [PATCH] Honor sysconfdir when set as an configure option Kacper Kornet
2011-04-28 21:05 ` Junio C Hamano
2011-04-28 21:22 ` Kacper Kornet
2011-05-03 6:42 ` [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir Johannes Sixt
2011-05-03 17:32 ` Junio C Hamano
2011-05-04 5:52 ` Johannes Sixt [this message]
2011-05-04 13:58 ` Kacper Kornet
2011-05-04 14:39 ` Johannes Sixt
2011-05-04 18:21 ` Junio C Hamano
2011-05-05 2:26 ` Junio C Hamano
2011-05-05 5:58 ` Johannes Sixt
2011-05-05 16:17 ` Junio C Hamano
2011-05-06 7:03 ` Johannes Sixt
2011-05-05 14:29 ` Kacper Kornet
2011-05-05 14:45 ` Johannes Sixt
2011-05-05 15:00 ` Kacper Kornet
2011-05-05 15:46 ` Junio C Hamano
2011-05-09 8:24 ` Johannes Sixt
2011-05-09 11:56 ` Kacper Kornet
2011-05-27 8:17 ` Kacper Kornet
2011-05-05 15:25 ` Kacper Kornet
2011-05-04 14:29 ` Kacper Kornet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC0E99E.6090402@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kornet@camk.edu.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).