[PATCH] shell: add missing initialization of argv0_path

[PATCH] shell: add missing initialization of argv0_path

[Dima Sharov]

According to c6dfb39 (remote-curl: add missing initialization of
argv0_path, 2009-10-13), stand-alone programs (non-builtins)
must call git_extract_argv0_path(argv[0]) in order to help builds
that derive the installation prefix at runtime. Without this call,
the program segfaults (or raises an assertion failure).

Signed-off-by: Dima Sharov <git.avalakvista@gmail.com>
---
 shell.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/shell.c b/shell.c
index dea4cfd..abb8622 100644
--- a/shell.c
+++ b/shell.c
@@ -137,6 +137,8 @@ int main(int argc, char **argv)
 	int devnull_fd;
 	int count;
 
+	git_extract_argv0_path(argv[0]);
+
 	/*
 	 * Always open file descriptors 0/1/2 to avoid clobbering files
 	 * in die().  It also avoids not messing up when the pipes are
-- 
1.7.2.3

[PATCH] shell: add missing initialization of argv0_path

[Dima Sharov]

According to c6dfb39 (remote-curl: add missing initialization of
argv0_path, 2009-10-13), stand-alone programs (non-builtins)
must call git_extract_argv0_path(argv[0]) in order to help builds
that derive the installation prefix at runtime. Without this call,
the program segfaults (or raises an assertion failure).

Signed-off-by: Dima Sharov <git.avalakvista@gmail.com>
---
shell.c |    2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/shell.c b/shell.c
index dea4cfd..abb8622 100644
--- a/shell.c
+++ b/shell.c
@@ -137,6 +137,8 @@ int main(int argc, char **argv)
	int devnull_fd;
	int count;

+	git_extract_argv0_path(argv[0]);
+
	/*
	 * Always open file descriptors 0/1/2 to avoid clobbering files
	 * in die().  It also avoids not messing up when the pipes are
-- 
1.7.2.3

Re: [PATCH] shell: add missing initialization of argv0_path

[Johannes Sixt]

Am 5/5/2011 8:40, schrieb Dima Sharov:
> According to c6dfb39 (remote-curl: add missing initialization of
> argv0_path, 2009-10-13), stand-alone programs (non-builtins)
> must call git_extract_argv0_path(argv[0]) in order to help builds
> that derive the installation prefix at runtime. Without this call,
> the program segfaults (or raises an assertion failure).

Good catch! I checked PROGRAM_OBJS in Makefile, and shell.c was the only
one remaining that did not call this function.

-- Hannes

Re: [PATCH] shell: add missing initialization of argv0_path

[Junio C Hamano]

Johannes Sixt <j.sixt@viscovery.net> writes:

> Am 5/5/2011 8:40, schrieb Dima Sharov:
>> According to c6dfb39 (remote-curl: add missing initialization of
>> argv0_path, 2009-10-13), stand-alone programs (non-builtins)
>> must call git_extract_argv0_path(argv[0]) in order to help builds
>> that derive the installation prefix at runtime. Without this call,
>> the program segfaults (or raises an assertion failure).
>
> Good catch! I checked PROGRAM_OBJS in Makefile, and shell.c was the only
> one remaining that did not call this function.

Thanks for an Ack; the patch was corrupt but was trivial to fix-up.
Will queue.