From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Brian Gernhardt <brian@gernhardtsoftware.com>,
"git@vger.kernel.org List" <git@vger.kernel.org>
Subject: Re: t5541: Bad file descriptor
Date: Thu, 05 May 2011 22:42:23 +0200 [thread overview]
Message-ID: <4DC30BAF.2060009@kdbg.org> (raw)
In-Reply-To: <20110505061845.GC29033@sigill.intra.peff.net>
Am 05.05.2011 08:18, schrieb Jeff King:
> OK, embarrassing. 09c9957 completely breaks smart http pushing. My
> testing of Johannes' patch was completely focused on the error case, and
> I didn't have a single test for the non-error case. And on top of that,
> we _have_ nice tests in the test suite to catch this, but obviously
> neither I, nor Johannes, nor Junio were running them (because they need
> apache installed and GIT_TEST_HTTPD set).
>
> Ugh.
>
> This patch on top of 09c9957 should fix it.
Very embarassing! Thanks for fixing up my mess. The patch looks good.
-- Hannes
prev parent reply other threads:[~2011-05-05 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 4:49 t5541: Bad file descriptor Brian Gernhardt
2011-05-05 5:35 ` Junio C Hamano
2011-05-05 5:46 ` Jeff King
2011-05-05 6:16 ` Jeff King
2011-05-05 11:18 ` Sverre Rabbelier
2011-05-05 17:59 ` Avery Pennarun
2011-05-05 18:51 ` Sverre Rabbelier
2011-05-09 14:50 ` Jeff King
2011-05-05 6:18 ` Jeff King
2011-05-05 6:57 ` Brian Gernhardt
2011-05-05 20:42 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC30BAF.2060009@kdbg.org \
--to=j6t@kdbg.org \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).