From: Michael J Gruber <git@drmicha.warpmail.net>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: git@vger.kernel.org
Subject: Re: Question about PERL_PATH
Date: Fri, 06 May 2011 17:56:45 +0200 [thread overview]
Message-ID: <4DC41A3D.10104@drmicha.warpmail.net> (raw)
In-Reply-To: <4DC3F804.3080205@mev.co.uk>
Ian Abbott venit, vidit, dixit 06.05.2011 15:30:
> The Gentoo ebuilds for git have started invoking 'make' with the option
> 'PERL_PATH=/usr/bin/env perl'. This doesn't seem to cause any problems
> except when running git instaweb, which outputs an error similar to the
> following:
Well, it means that all our perl scripts are run with the perl which is
the first in PATH at run time (for the user running it), which may or
may not be the one which is first in PATH at build or test time (for the
user running that).
Of course there's no problem when they are the same.
> /usr/libexec/git-core/git-instaweb: line 135: /usr/bin/env perl: No such
> file or directory
>
> There is an easy workaround, which is to modify the invocation of perl
> in the httpd_is_ready() function in the git-instaweb shell script. It
> currently invokes perl as "$PERL" (with the quotes). Removing the
> quotes makes it work.
>
> My question is, should git support Gentoo's unusual setting of PERL_PATH
> as a multi-word command, or should Gentoo patch around the problem they
> have created with git-instaweb themselves?
>
> There is one other place where $PERL is used in git-instaweb and that is
> in the mongoose_conf() function. It has a heredoc that puts the
> following line in the httpd.conf file (subject to shell variable expansion):
>
> cgi_interp $PERL
>
> For Gentoo, that would get expanded to the following:
>
> cgi_interp /usr/bin/env perl
>
> I don't know if Mongoose would choke on this or not.
For a system wide installed package, it just seems like a crazy idea to
package it in a way which makes it depend on the contents of users'
$HOME/bin and such. What kind of packaging is that? I mean, package git
depends on package perl, but then leave the meaning of "perl" at the
users' discretion and mercy...
Michael
next prev parent reply other threads:[~2011-05-06 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 13:30 Question about PERL_PATH Ian Abbott
2011-05-06 15:56 ` Michael J Gruber [this message]
2011-05-06 16:05 ` Junio C Hamano
2011-05-06 16:42 ` Ian Abbott
2011-05-07 18:02 ` Robin H. Johnson
2011-05-08 0:13 ` Jeff King
2011-05-09 14:49 ` Drew Northup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC41A3D.10104@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=abbotti@mev.co.uk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).