From: "Arend van Spriel" <arend@broadcom.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Michael J Gruber" <git@drmicha.warpmail.net>,
"\"Grundler <grundler\"@chromium.org <Grundler"
<grundler@chromium.org>, "Greg Kroah-Hartman" <greg@kroah.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"Dowan Kim" <dowan@broadcom.com>,
"Henry Ptasinski" <henryp@broadcom.com>,
"Venkat Rao" <vrao@broadcom.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] staging: brcm80211: SDIO/MMC cleanups
Date: Fri, 6 May 2011 18:44:18 +0200 [thread overview]
Message-ID: <4DC42562.5080308@broadcom.com> (raw)
In-Reply-To: <7v39kr3j8r.fsf@alter.siamese.dyndns.org>
On 05/06/2011 06:07 PM, Junio C Hamano wrote:
> Michael J Gruber<git@drmicha.warpmail.net> writes:
>
>> Junio C Hamano venit, vidit, dixit 06.05.2011 16:37:
>>> "Arend van Spriel"<arend@broadcom.com> writes:
>>>
>>>> The git documentation on the git am command is not very elaborate. I
>>>> investigated the issue and checked following:
>>>> 1. line 135 in dhd_sdio.c in the patch does match line 135 in my
>>>> checked out branch.
>>> Does it exactly match, or does it merely visually match if you ignore tabs
>>> and spaces munged by somebody between the state of the file submitter
>>> committed and grunder.eml file you stored?
>> Junio, he reported the hashes to match! Puzzling. Or a MUA doing things
>> to the .eml.
> The latter is exactly what I meant. The mailchain leading to the
> receiver's mailbox would not adjust the hash recorded in the patch when it
> munges whitespaces.
Tried patch -p1 < grundler.eml. That gives info at which line it fails.
I believe we have to blame Thunderbird here as you suspected. It placed
a line break because to line was too long. Crap! Why do tools have to be
"smart"?
Gr. AvS
next prev parent reply other threads:[~2011-05-06 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110504165947.40EED208186@grundler.mtv.corp.google.com>
2011-05-06 8:25 ` [PATCH] staging: brcm80211: SDIO/MMC cleanups Arend van Spriel
2011-05-06 14:37 ` Junio C Hamano
2011-05-06 16:00 ` Michael J Gruber
2011-05-06 16:07 ` Junio C Hamano
2011-05-06 16:44 ` Arend van Spriel [this message]
2011-05-06 15:21 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC42562.5080308@broadcom.com \
--to=arend@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=dowan@broadcom.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=greg@kroah.com \
--cc=grundler@chromium.org \
--cc=henryp@broadcom.com \
--cc=vrao@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).