From: Sebastian Schuberth <sschuberth@gmail.com>
To: git@vger.kernel.org
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH/RFC v2] Do not strip empty lines / trailing spaces from a commit message template
Date: Sun, 08 May 2011 14:28:56 +0200 [thread overview]
Message-ID: <4DC68C88.7030604@gmail.com> (raw)
In-Reply-To: <1304850662-6424-1-git-send-email-billiob@gmail.com>
On 08.05.2011 12:31, Boris Faure wrote:
> Templates should be just that: A form that the user fills out, and forms
> have blanks. If people are attached to not having extra whitespace in the
> editor, they can simply clean up their templates.
>
> Added test with editor adding even more whitespace.
>
> Signed-off-by: Boris Faure<billiob@gmail.com>
> Based-on-patch-by:Sebastian Schuberth<sschuberth@gmail.com>
Thanks for rebasing the patch and adding the test! I've run the whole
test suite on Linux, and all tests pass for me (including the added one).
--
Sebastian Schuberth
next prev parent reply other threads:[~2011-05-08 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 15:53 [PATCH 1/2] commit: do not cleanup template Boris Faure
2011-05-07 15:53 ` [PATCH 2/2] commit: do not add a newline after a template Boris Faure
2011-05-07 20:13 ` [PATCH 1/2] commit: do not cleanup template Junio C Hamano
2011-05-07 21:17 ` Boris 'billiob' Faure
2011-05-07 22:31 ` Junio C Hamano
2011-05-08 8:38 ` Sebastian Schuberth
2011-05-08 8:47 ` Sebastian Schuberth
2011-05-08 10:31 ` [PATCH/RFC v2] Do not strip empty lines / trailing spaces from a commit message template Boris Faure
2011-05-08 12:28 ` Sebastian Schuberth [this message]
2011-05-08 18:14 ` Junio C Hamano
2011-05-08 18:55 ` [PATCH/RFC v3] " Boris Faure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC68C88.7030604@gmail.com \
--to=sschuberth@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).