From: Michael Schubert <mschub@elegosoft.com>
To: git@vger.kernel.org
Subject: [PATCH] lock_any_ref_for_update(): clarify switch case statement
Date: Tue, 10 May 2011 13:48:01 +0200 [thread overview]
Message-ID: <4DC925F1.4060307@elegosoft.com> (raw)
Write CHECK_REF_FORMAT_OK instead of '0' to be more verbose.
Signed-off-by: Michael Schubert <mschub@elegosoft.com>
---
refs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/refs.c b/refs.c
index e3c0511..67d6bbd 100644
--- a/refs.c
+++ b/refs.c
@@ -1092,7 +1092,7 @@ struct ref_lock *lock_any_ref_for_update(const char *ref, const unsigned char *o
switch (check_ref_format(ref)) {
default:
return NULL;
- case 0:
+ case CHECK_REF_FORMAT_OK:
case CHECK_REF_FORMAT_ONELEVEL:
return lock_ref_sha1_basic(ref, old_sha1, flags, NULL);
}
--
1.7.5.1
next reply other threads:[~2011-05-10 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 11:48 Michael Schubert [this message]
2011-05-10 20:07 ` [PATCH] lock_any_ref_for_update(): clarify switch case statement Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC925F1.4060307@elegosoft.com \
--to=mschub@elegosoft.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).