From: Jens Lehmann <Jens.Lehmann@web.de>
To: Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [RFC PATCH 0/2] better handle .gitmodules merge conflicts
Date: Thu, 12 May 2011 23:01:17 +0200 [thread overview]
Message-ID: <4DCC4A9D.3060007@web.de> (raw)
This series contains a test to reproduce and a first attempt to fix the
problem that "git diff", "git status" and "git fetch" die early when the
.gitmodules file contains merge conflict markers. As I am not aware of any
bug reports yet it looks like that either doesn't happen very often in the
wild ("git diff" parses the .gitmodules file since 1.7.3, but even as
heavy submodule users we only hit this once just recently) or the users
encountering this problem just know what to do: resolve the conflict and
carry on.
But that is no excuse to behave so unfriendly, especially as this can
happen in a completely normal workflow, when e.g. two users are adding
different submodules in separate branches and they get merged. So this
RFC patch is my first attempt to avoid those commands dying.
In a second step a merge helper capable of merging inifiles would make
sense. This should be enabled for the .gitmodules file by default and
avoid most of the merge conflicts, e.g. when two users add different
submodules in separate branches. But that is a different patch ...
Heiko Voigt (1):
test that git status works with merge conflict in .gitmodules
Jens Lehmann (1):
Submodules: Don't parse .gitmodules when it contains merge conflicts
submodule.c | 23 +++++++++-
t/t7506-status-submodule.sh | 100 +++++++++++++++++++++++++++++++++++++++++--
2 files changed, 117 insertions(+), 6 deletions(-)
--
1.7.5.1.251.ga75dd
next reply other threads:[~2011-05-12 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 21:01 Jens Lehmann [this message]
2011-05-12 21:02 ` [RFC PATCH 1/2] test that git status works with merge conflict in .gitmodules Jens Lehmann
2011-05-13 5:47 ` Junio C Hamano
2011-05-12 21:03 ` [RFC PATCH 2/2] Submodules: Don't parse .gitmodules when it contains merge conflicts Jens Lehmann
2011-05-13 6:19 ` Junio C Hamano
2011-05-13 15:01 ` [RFC PATCH 0/2] better handle .gitmodules " Marc Branchaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCC4A9D.3060007@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).