git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ferry Huberts <mailings@hupie.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git & patterns
Date: Thu, 19 May 2011 08:23:46 +0200	[thread overview]
Message-ID: <4DD4B772.2050404@hupie.com> (raw)
In-Reply-To: <7vsjsbbx7h.fsf@alter.siamese.dyndns.org>

On 05/18/2011 09:55 PM, Junio C Hamano wrote:
> Ferry Huberts <mailings@hupie.com> writes:
> 
>> After reading the manual page for git describe it was not clear to me what
>> kind of pattern the --match option should take. Was it to be
>> a shell pattern (to be expected) or a regular expression pattern?
>>
>> So I dug in the code to find fnmatch: shell pattern.
>>
>> Now my question(s):
>>
>> - could the manual page be update to make this explicit please? (plus
>> other manual pages talking about (shell) patterns)
> 
> The general design guideline we have is to use glob for things that look
> like pathnames. Refs, refspecs, ignore and attribute rules are the
> examples of this rule.
> 

Well, to me tags do not look like pathnames at all, they're just
'random' strings. As are branches.
Technically they may be like pathnames because they're projected on to
the filesystem that way, but principally they're not IMHO: it's an
implementation detail.

> We may be lacking this info in our documentation. A patch to add it
> somewhere is very welcome.

Yesterday I already did a quick grep on pattern and glob in the
documentation directory and found that:
- usually patterns are just patterns, without specifying what kind
- when a pattern type is specified it most of the time is a glob pattern
- but sometimes it is called a shell pattern
- and  a few cases speak of a wildcard pattern (I think)

What should it be?
From your comments I gather it should be a glob pattern.
Isn't glob too 'tech speak' or is it acceptable?
If not acceptable, then what? Shell wildcard pattern?

thanks!

-- 
Ferry Huberts

  reply	other threads:[~2011-05-19  6:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 10:48 git & patterns Ferry Huberts
2011-05-18 13:07 ` Andreas Ericsson
2011-05-18 13:36   ` Ferry Huberts
2011-05-18 19:55 ` Junio C Hamano
2011-05-19  6:23   ` Ferry Huberts [this message]
2011-05-19  6:40     ` Tim Mazid
2011-05-19  6:43       ` Tim Mazid
2011-05-19  6:46         ` Ferry Huberts
2011-05-19  6:54           ` Tim Mazid
2011-05-19  6:47     ` Junio C Hamano
2011-05-19  6:54       ` Ferry Huberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD4B772.2050404@hupie.com \
    --to=mailings@hupie.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).