git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Brian Gernhardt <brian@gernhardtsoftware.com>
Cc: "git@vger.kernel.org List" <git@vger.kernel.org>
Subject: Re: t7810.94 (git-grep -E -F -G) never passed
Date: Wed, 25 May 2011 12:21:57 +0200	[thread overview]
Message-ID: <4DDCD845.1030800@drmicha.warpmail.net> (raw)
In-Reply-To: <BE19630B-8E48-4CA8-B956-A4DC767BFFDD@gernhardtsoftware.com>

Brian Gernhardt venit, vidit, dixit 25.05.2011 05:27:
> I'm not sure why it's supposed to pass, actually.  -G makes the pattern be a basic regex and basic regexen don't recognize the + repetition operator.
> 
> expecting success: 
> 	echo ab:aab >expected &&
> 	git grep -E -F -G a\\+b >actual &&
> 	test_cmp expected actual
> 
> --- expected	2011-05-25 03:19:05.000000000 +0000
> +++ actual	2011-05-25 03:19:05.000000000 +0000
> @@ -1 +1 @@
> -ab:aab
> +ab:a+b
> not ok - 94 grep -E -F -G pattern

"Never" is a strong statement when this test always passed for everyone
else running tests, assuming they would have reported otherwise. What's
your system?

reg-ex.info says:

"The other BRE metacharacters require a backslash to give them their
special meaning."

"Some implementations support \? and \+... but \? and \+ are not part of
the POSIX standard."

So I guess we're going with "some".

Michael

  reply	other threads:[~2011-05-25 10:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25  3:27 t7810.94 (git-grep -E -F -G) never passed Brian Gernhardt
2011-05-25 10:21 ` Michael J Gruber [this message]
2011-05-25 12:48   ` Brian Gernhardt
2011-05-25 21:22     ` Michał Kiedrowicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDCD845.1030800@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).