From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Lehmann Subject: Re: [PATCH 0/3] submodule add: allow relative repository path even when no url is set Date: Mon, 06 Jun 2011 23:39:35 +0200 Message-ID: <4DED4917.7020408@web.de> References: <7vaae2ihe1.fsf@alter.siamese.dyndns.org> <1306943792-1825-1-git-send-email-marcnarc@xiplink.com> <7vsjrth4iy.fsf@alter.siamese.dyndns.org> <4DE69945.1080601@web.de> <7v39jsdulf.fsf@alter.siamese.dyndns.org> <4DE93B29.4030401@web.de> <7vipskb0br.fsf@alter.siamese.dyndns.org> <4DED30E0.6090608@web.de> <7vei368ylj.fsf@alter.siamese.dyndns.org> <4DED454B.1050105@xiplink.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Junio C Hamano , git@vger.kernel.org, Mark Levedahl , Phil Hord To: Marc Branchaud X-From: git-owner@vger.kernel.org Mon Jun 06 23:39:46 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QThWT-000746-4o for gcvg-git-2@lo.gmane.org; Mon, 06 Jun 2011 23:39:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753703Ab1FFVjk (ORCPT ); Mon, 6 Jun 2011 17:39:40 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:34581 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752569Ab1FFVjj (ORCPT ); Mon, 6 Jun 2011 17:39:39 -0400 Received: from smtp01.web.de ( [172.20.0.243]) by fmmailgate03.web.de (Postfix) with ESMTP id ADB4819193717; Mon, 6 Jun 2011 23:39:38 +0200 (CEST) Received: from [93.240.124.249] (helo=[192.168.178.43]) by smtp01.web.de with asmtp (WEB.DE 4.110 #2) id 1QThWM-0005C3-00; Mon, 06 Jun 2011 23:39:38 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 In-Reply-To: <4DED454B.1050105@xiplink.com> X-Sender: Jens.Lehmann@web.de X-Provags-ID: V01U2FsdGVkX198Kwx7rQL61vP7hQm0XSui3EmJsVr42jUmF0q3 NTkCz7QAMqxR0ovEotZfQm8+6hhQwYbrcf47jiBjLvJ9MsJchb tbBMZ8DO6qKOLRtnueyA== Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Am 06.06.2011 23:23, schrieb Marc Branchaud: > On 11-06-06 05:00 PM, Junio C Hamano wrote: >> Jens Lehmann writes: >> >>> Am 05.06.2011 20:27, schrieb Junio C Hamano: >>>> If you think about "absense of the remote in the superproject means the >>>> project originates from here", what you are doing in step 3. is to >>>> changing the origin of these set of projects. After changing the origin of >>>> these set of projects, isn't "git submodule sync" an established way to >>>> adjust to the change? I was hoping that that would update .git/config in >>>> step 3. so you wouldn't have the problem in step 4. at all. >>> >>> Thanks for explaining that in detail, I think I do get it now. >> >> I actually still have a feeling that I may be missing something from the >> discussion. While I do like a solution that lifts existing limitation to >> allow workflows that were hitherto impossible, that only makes sense when >> the newly allowed workflow makes sense and useful, and when the lifted >> limitation was not protecting some silly mistakes from getting made. That's why I started with an improved error message and documentation ;-) >> I _think_ our last exchange gave me a fuzzy confirmation that we are not >> lifting a useful limitation, but I still do not know if the new workflow >> matches the workflow Marc (who kicked off this thread) wanted to use. I >> think it does match the set-up Phil Hord mentioned in an earlier message, >> though. > > Well, Jens's changes do remove the error I encountered, and they also do what > I was expecting in the original context I was in when I started this thread. > So I think this is a definite improvement. Thanks. > There may still be a lingering niggle where git might do something the user > doesn't expect. For example, git might create a submodule out of > git://origin/foo.git instead of the local ../foo.git. You have to be paying > attention to git's output to notice that difference, and I could see where a > user might get tripped up. But IMO improving this can be done independently > of Jens's patches. Maybe Phil's opinion could be helpful here as he seems to be a heavy user of relative submodule urls.