From: Johannes Sixt <j.sixt@viscovery.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t3703: skip more tests using colons in file names on Windows
Date: Wed, 08 Jun 2011 08:22:36 +0200 [thread overview]
Message-ID: <4DEF152C.5060005@viscovery.net> (raw)
In-Reply-To: <BANLkTik3K2GVZ5rzegYSXRrvROU_bzBdVw@mail.gmail.com>
Am 6/7/2011 15:43, schrieb Alex Riesen:
> Use the same test and prerequisite as introduced in similar
> fix in 650af7ae8bdf92bd92df2.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>
> Why didn't Johannes noticed it, I wonder. The failing test was
> here all the time.
Good catch! Here's the explanation:
> -test_expect_success 'a file with the same (long) magic name exists' '
> - : >":(icase)ha" &&
":foo" is the name of an alternate data stream on the current directory.
Bash can successfully open and write such a "file". (But there is no way
to list it, even though test -f detects its existence.)
> - test_must_fail git add -n ":(icase)ha" &&
This 'git add' fails, either for the intended reason, or because regular
directory listing functions do not detect the alternate data stream; I do
not know.
> - git add -n "./:(icase)ha"
This obviously succeeds because a regular open() call can open the
alternate data stream just like any file.
Therefore, the test passes. This is on Windows XP with NTFS.
-- Hannes
next prev parent reply other threads:[~2011-06-08 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 13:43 [PATCH] t3703: skip more tests using colons in file names on Windows Alex Riesen
2011-06-08 6:22 ` Johannes Sixt [this message]
2011-06-08 10:44 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEF152C.5060005@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).