From: Mark Levedahl <mlevedahl@gmail.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Erik Faye-Lund <kusmabite@gmail.com>,
Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH 1/3] help.c: Fix detection of custom merge strategy on cygwin
Date: Sat, 18 Jun 2011 18:46:16 -0400 [thread overview]
Message-ID: <4DFD2AB8.2050907@gmail.com> (raw)
In-Reply-To: <4DFCD8E1.3060102@ramsay1.demon.co.uk>
On 06/18/2011 12:57 PM, Ramsay Jones wrote:
>
> Anyway, if you don't mind executing the "WIN32 code block" unnecessarily
> on cygwin (I don't think it would be too expensive) then we could simply
> reduce the patch to:
>
> -#ifdef WIN32
> +#if defined(WIN32) || defined(__CYGWIN__)
> { /* cannot trust the executable bit, peek into the file instead */
>
> (I've simply typed the above in my MUA, so not tested, obviously!)
>
> This is exactly what Johannes proposed last year. :)
>
> ATB,
> Ramsay Jones
>
Please, no. Cygwin's git is already slow enough, and adding yet another
peek into a file *after* cygwin already did that is just making it worse.
(Muttering to self: Cygwin's goal is to replicate Linux / Posix behavior
under Windows, why did git ever adopt code to make cygwin more like
Windows rather than just treating cygwin as another Posix'y environment?
Those who want more speed really should just be using the native win32
port and deal with the lack of file modes, crlf issues, etc.)
Mark
prev parent reply other threads:[~2011-06-18 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 20:22 [PATCH 1/3] help.c: Fix detection of custom merge strategy on cygwin Ramsay Jones
2011-06-16 22:24 ` Junio C Hamano
2011-06-18 16:57 ` Ramsay Jones
2011-06-18 22:46 ` Mark Levedahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFD2AB8.2050907@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=kusmabite@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).