From: Phil Hord <hordp@cisco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Maarten Billemont" <lhunath@gmail.com>,
"Jens Lehmann" <Jens.Lehmann@web.de>,
"Git Mailing List" <git@vger.kernel.org>,
"Andreas Köhler" <andi5.py@gmx.net>
Subject: Re: ''git submodule sync'' should not add uninitialized submodules to .git/config
Date: Thu, 23 Jun 2011 19:06:31 -0400 [thread overview]
Message-ID: <4E03C6F7.2010506@cisco.com> (raw)
In-Reply-To: <7vhb7g2pbf.fsf@alter.siamese.dyndns.org>
On 06/23/2011 05:47 PM, Junio C Hamano wrote:
> Phil Hord <hordp@cisco.com> writes:
>
>> On 06/23/2011 10:35 AM, Junio C Hamano wrote:
>>>> Now, when I run git submodule update, it starts checking out the third
>>>> module and my workflow is broken.
>>> See 33f072f (submodule sync: Update "submodule.<name>.url" for empty
>>> directories, 2010-10-08), which introduced this behaviour.
>>>
>>> cmd_update considers anything that has submodule.<name>.url defined as
>>> "the user is interested", so I suspect "git submodule sync" should not do
>>> this.
>> What about a compromise? Change git-submodule-sync to skip submodules
>> which are not already initialized.
> You completely lost me. How's that different from reverting 33f072f? I do
> not see a room for "compromise" here.
Your patch does what I meant, so I assume you figured out my compromise.
My patch was simpler, but I haven't tested it properly yet.
Phil
prev parent reply other threads:[~2011-06-23 23:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 11:13 ''git submodule sync'' should not add uninitialized submodules to .git/config Maarten Billemont
2011-06-23 13:39 ` Phil Hord
2011-06-23 14:35 ` Junio C Hamano
2011-06-23 19:14 ` Jens Lehmann
2011-06-23 22:28 ` Junio C Hamano
2011-06-23 23:10 ` Andreas Köhler
2011-06-24 6:17 ` Jens Lehmann
2011-06-24 4:13 ` Re* " Junio C Hamano
2011-06-24 6:20 ` Jens Lehmann
2011-06-25 23:26 ` [PATCH] submodule add: always initialize .git/config entry Jens Lehmann
2011-06-30 0:47 ` Junio C Hamano
2011-06-25 20:41 ` [PATCH v2] submodule sync: do not auto-vivify uninteresting submodule Jens Lehmann
2011-06-23 20:01 ` ''git submodule sync'' should not add uninitialized submodules to .git/config Phil Hord
2011-06-23 21:47 ` Junio C Hamano
2011-06-23 23:06 ` Phil Hord [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E03C6F7.2010506@cisco.com \
--to=hordp@cisco.com \
--cc=Jens.Lehmann@web.de \
--cc=andi5.py@gmx.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lhunath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).