From: Jens Lehmann <Jens.Lehmann@web.de>
To: "Andreas Köhler" <andi5.py@gmx.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Maarten Billemont <lhunath@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: ''git submodule sync'' should not add uninitialized submodules to .git/config
Date: Fri, 24 Jun 2011 08:17:30 +0200 [thread overview]
Message-ID: <4E042BFA.3020909@web.de> (raw)
In-Reply-To: <4E03C7E5.4050008@gmx.net>
Am 24.06.2011 01:10, schrieb Andreas Köhler:
> There are two minor issues for me left.
> (1) The man page of submodule sync talks about "all submodules" and not
> "registered submodules". I treated it as "subsequent init" and
> personally do not restrict the list of submodules, simply because my
> build would not work without them.
While investigating this I stumbled across that too, will post a patch.
> (2) It is confusing to have registered submodules in .git/config without
> a matching gitlink. Say, you switch between branch a1 with a submodule s
> with url u1, to a branch without s, you git clean -xdff (url u1 is still
> in .git/config, right?), and then to a branch a2 with s pointing to url
> u2. This bugged me.
I think that is ok, because that way git remembers that the user cares
about submodule s even when he switches to a branch where s doesn't
exist. And the documentation is pretty clear that you'll have to use
"git submodule sync" to update the url itself from u1 to u2 when needed.
next prev parent reply other threads:[~2011-06-24 6:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 11:13 ''git submodule sync'' should not add uninitialized submodules to .git/config Maarten Billemont
2011-06-23 13:39 ` Phil Hord
2011-06-23 14:35 ` Junio C Hamano
2011-06-23 19:14 ` Jens Lehmann
2011-06-23 22:28 ` Junio C Hamano
2011-06-23 23:10 ` Andreas Köhler
2011-06-24 6:17 ` Jens Lehmann [this message]
2011-06-24 4:13 ` Re* " Junio C Hamano
2011-06-24 6:20 ` Jens Lehmann
2011-06-25 23:26 ` [PATCH] submodule add: always initialize .git/config entry Jens Lehmann
2011-06-30 0:47 ` Junio C Hamano
2011-06-25 20:41 ` [PATCH v2] submodule sync: do not auto-vivify uninteresting submodule Jens Lehmann
2011-06-23 20:01 ` ''git submodule sync'' should not add uninitialized submodules to .git/config Phil Hord
2011-06-23 21:47 ` Junio C Hamano
2011-06-23 23:06 ` Phil Hord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E042BFA.3020909@web.de \
--to=jens.lehmann@web.de \
--cc=andi5.py@gmx.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lhunath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).