From: Eric Raible <raible@nextest.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: BUG: 'cherry-pick -x' corner case
Date: Fri, 24 Jun 2011 14:54:49 -0700 [thread overview]
Message-ID: <4E0507A9.7090000@nextest.com> (raw)
When cherry-picking a (presumably trivial) commit that has only
the one-line summary (and no further text), cherry-pick -x appends
it's message directly to the one-line summary.
Thereby creating a commit which has a two-line summary.
Aside from that, even with a non-trivial commit the generated note
"(cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)"
seems abrupt when appended directly.
I'd suggest:
"\n[cherry-picked from commit 555c9864971744abb558796aea28e12a1ac20839]"
or even better:
"\n[cherry-picked from commit 555c986]"
I'll turn this into an actual patch if there's a chance of it being incorporated.
- Eric
reply other threads:[~2011-06-24 22:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0507A9.7090000@nextest.com \
--to=raible@nextest.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).