* BUG: 'cherry-pick -x' corner case
@ 2011-06-24 21:54 Eric Raible
0 siblings, 0 replies; only message in thread
From: Eric Raible @ 2011-06-24 21:54 UTC (permalink / raw)
To: git@vger.kernel.org, Junio C Hamano
When cherry-picking a (presumably trivial) commit that has only
the one-line summary (and no further text), cherry-pick -x appends
it's message directly to the one-line summary.
Thereby creating a commit which has a two-line summary.
Aside from that, even with a non-trivial commit the generated note
"(cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)"
seems abrupt when appended directly.
I'd suggest:
"\n[cherry-picked from commit 555c9864971744abb558796aea28e12a1ac20839]"
or even better:
"\n[cherry-picked from commit 555c986]"
I'll turn this into an actual patch if there's a chance of it being incorporated.
- Eric
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-06-24 22:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-24 21:54 BUG: 'cherry-pick -x' corner case Eric Raible
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).