git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: git push vs. slow connection times - local commit resolution is too late
Date: Thu, 14 Jul 2011 07:22:50 -0600	[thread overview]
Message-ID: <4E1EEDAA.1000204@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

I've been bitten several times by this bug now, so I'll report it in the
hopes that someone knows what to do to patch it.

Scenario - I have a remote repository that takes on the order of 10
seconds to connect to, for any operation like 'git push'.  I know that
there is a lag, so I intentionally have two terminals open, both
visiting the same directory, one for interaction with the remote, and
the other for acting on the local repository, with the hope that I can
do useful work in the second terminal rather than idly waiting on the
lag in the first terminal.

In the middle of rebasing a patch series, where I want to incrementally
push the patches that I have gotten through so far, I used the following
steps:

On the remote-interaction terminal, I push the current state of my tree:
git push remote HEAD:master

On the local-interaction terminal, I move on to the next patch:
git rebase --continue

then, to my horror, I find out that the commit I'm working on locally
has already been pushed!  Why?  Because 'git push remote HEAD:master'
does not determine which commit 'HEAD' refers to until _after_ it has
established a connection to remote, but the stupid 10-second lag was
long enough that my actions in my second terminal have changed HEAD in
the meantime.

I would really love it if 'git push' would resolve all local references
_prior_ to trying to connect to the remote server, rather than waiting
until after the connection.  That way, my remote-interaction terminal
can truly be a type-it-and-forget-it terminal, where the push action I
requested reflects the state of the tree at the time I requested it,
rather than picking up changes made later in another terminal.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

             reply	other threads:[~2011-07-14 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 13:22 Eric Blake [this message]
2011-07-16  4:38 ` git push vs. slow connection times - local commit resolution is too late Phil Hord
2011-07-16 12:52   ` Andreas Schwab
2011-07-17 19:46     ` Phil Hord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1EEDAA.1000204@redhat.com \
    --to=eblake@redhat.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).