git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Add a test to check that git ls-tree sets non-zero exit code on error.
Date: Sat, 23 Jul 2011 20:01:44 +0200	[thread overview]
Message-ID: <4E2B0C88.1030906@web.de> (raw)
In-Reply-To: <1311424051-29644-2-git-send-email-jon.seymour@gmail.com>

Am 23.07.2011 14:27, schrieb Jon Seymour:
> Fails at this commit, fixed by subsequent commit.

Maybe use "test_expect_failure" here and change that to "test_expect_success"
in the next commit?

> Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
> ---
>  t/t3103-ls-tree-missing-tree.sh |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)
>  create mode 100755 t/t3103-ls-tree-missing-tree.sh
> 
> diff --git a/t/t3103-ls-tree-missing-tree.sh b/t/t3103-ls-tree-missing-tree.sh
> new file mode 100755
> index 0000000..365ac07
> --- /dev/null
> +++ b/t/t3103-ls-tree-missing-tree.sh
> @@ -0,0 +1,19 @@
> +#!/bin/sh
> +
> +test_description='ls-tree exits with non-zero status if it also reports an error'
> +
> +. ./test-lib.sh
> +
> +test_expect_success 'setup' '
> +	mkdir a &&
> +	touch a/one &&
> +	git add a/one &&
> +	git commit -m test
> +'
> +
> +test_expect_success 'ls-tree fails with non-zero exit code on broken tree' '
> +	rm -f .git/objects/5f/cffbd6e4c5c5b8d81f5e9314b20e338e3ffff5 &&
> +	test_must_fail git ls-tree -r HEAD
> +'
> +
> +test_done

  reply	other threads:[~2011-07-23 18:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-23 12:27 [PATCH 0/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails Jon Seymour
2011-07-23 12:27 ` [PATCH 1/2] Add a test to check that git ls-tree sets non-zero exit code on error Jon Seymour
2011-07-23 18:01   ` Jens Lehmann [this message]
2011-07-23 12:27 ` [PATCH 2/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails Jon Seymour
  -- strict thread matches above, loose matches on Subject: below --
2011-07-24  1:07 [PATCH 0/2 v2] ls-tree: exit with non-zero status on error Jon Seymour
2011-07-24  1:07 ` [PATCH 1/2] Add a test to check that git ls-tree sets non-zero exit code " Jon Seymour
2011-07-24  7:45   ` Junio C Hamano
2011-07-24  9:12     ` Jon Seymour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2B0C88.1030906@web.de \
    --to=jens.lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=jon.seymour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).