From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v3 2/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails.
Date: Mon, 25 Jul 2011 18:46:29 +0200 [thread overview]
Message-ID: <4E2D9DE5.1050502@web.de> (raw)
In-Reply-To: <CAH3Anrrbj93briHKpxEjpoVTOnSikQYQyxa4R=C7QKt=punyVw@mail.gmail.com>
Am 25.07.2011 10:45, schrieb Jon Seymour:
> Fair point.
>
> Everyone ok with this revision? If so, I will re-roll v4.
>
> Jens: I added the variable back because the return statement with a
> ternary operator needed a line break. Let me know
> if there is a better way to format it.
Now the extra variable makes sense to me, so I'm good too.
next prev parent reply other threads:[~2011-07-25 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 14:59 [PATCH v3 0/2] ls-tree: exit with non-zero status on error Jon Seymour
2011-07-24 14:59 ` [PATCH v3 1/2] Add a test to check that git ls-tree sets non-zero exit code " Jon Seymour
2011-07-24 14:59 ` [PATCH v3 2/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails Jon Seymour
2011-07-25 1:31 ` Nguyen Thai Ngoc Duy
2011-07-25 8:45 ` Jon Seymour
2011-07-25 12:58 ` Nguyen Thai Ngoc Duy
2011-07-25 16:17 ` Andreas Schwab
2011-07-25 16:46 ` Jens Lehmann [this message]
2011-07-25 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2D9DE5.1050502@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jon.seymour@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).