From: Pascal Obry <pascal@obry.net>
To: Theo Niessink <theo@taletn.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] On Cygwin support both UNIX and DOS style path-names
Date: Thu, 28 Jul 2011 11:28:54 +0200 [thread overview]
Message-ID: <4E312BD6.6020901@obry.net> (raw)
In-Reply-To: <FD5C22CB4AC2439D8151F6B7CD4B7CC9@martinic.local>
Theo,
>> +#define has_dos_drive_prefix(path) (isalpha(*(path))&& (path)[1] == ':')
>> +#define is_dir_sep(c) ((c) == '/' || (c) == '\\')
>
> I think that by defining is_dir_sep you enable DOS/Windows style paths
> throughout Git, so you might want to check compat/mingw.h for other, related
> changes. You will probably at least want the MinGW version of
> find_last_dir_sep as well, because the default find_last_dir_sep doesn't use
> is_dir_sep.
Thanks for the review/feedback. Will work on that and propose another patch.
Pascal.
--
--|------------------------------------------------------
--| Pascal Obry Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--| http://www.obry.net - http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B
next prev parent reply other threads:[~2011-07-28 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 15:57 [PATCH] On Cygwin support both UNIX and DOS style path-names Theo Niessink
2011-07-28 9:28 ` Pascal Obry [this message]
2011-07-28 10:44 ` Theo Niessink
-- strict thread matches above, loose matches on Subject: below --
2011-07-25 17:27 Pascal Obry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E312BD6.6020901@obry.net \
--to=pascal@obry.net \
--cc=git@vger.kernel.org \
--cc=theo@taletn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).