From: Jon Forrest <nobozo@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fixed pluralization in diff reports
Date: Sun, 31 Jul 2011 21:11:39 -0700 [thread overview]
Message-ID: <4E36277B.9020208@gmail.com> (raw)
In-Reply-To: <7v8vrdkc19.fsf@alter.siamese.dyndns.org>
On 7/31/2011 9:09 PM, Junio C Hamano wrote:
> Jon Forrest<nobozo@gmail.com> writes:
>
>> I got irritated by the
>>
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> This is how the other diff implementation has always showed this line, no?
Maybe, but it's not grammatical English no matter who does it.
But, I'm in the process of asking you to disregard this change
because I noticed that the diff of my change to diff.c was
1 file changed, 6 insertions(+), 4 deletion(-)
The last part is clearly wrong, but I don't see why
my change didn't work. It's such a simple change.
Back to the drawing board.
Sorry for the bother.
Jon
next prev parent reply other threads:[~2011-08-01 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 4:00 [PATCH] Fixed pluralization in diff reports Jon Forrest
2011-08-01 4:09 ` Junio C Hamano
2011-08-01 4:11 ` Jon Forrest [this message]
2011-08-01 5:06 ` Junio C Hamano
2011-08-01 5:09 ` Jon Forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E36277B.9020208@gmail.com \
--to=nobozo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).