From: Jon Forrest <nobozo@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fixed pluralization in diff reports
Date: Sun, 31 Jul 2011 22:09:23 -0700 [thread overview]
Message-ID: <4E363503.6050102@gmail.com> (raw)
In-Reply-To: <7v4o21k9e9.fsf@alter.siamese.dyndns.org>
On 7/31/2011 10:06 PM, Junio C Hamano wrote:
> Jon Forrest<nobozo@gmail.com> writes:
>
>>> This is how the other diff implementation has always showed this line, no?
>>
>> Maybe, but it's not grammatical English no matter who does it.
>
> It does not matter it is grammatical or not; changing it would break
> expectation by scripts that are used to the output both by the other
> implementation and by us.
I see your point. I agree that this change isn't important
enough to disturb so many things. I didn't realize this
would happen.
Sorry,
Jon
prev parent reply other threads:[~2011-08-01 5:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 4:00 [PATCH] Fixed pluralization in diff reports Jon Forrest
2011-08-01 4:09 ` Junio C Hamano
2011-08-01 4:11 ` Jon Forrest
2011-08-01 5:06 ` Junio C Hamano
2011-08-01 5:09 ` Jon Forrest [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E363503.6050102@gmail.com \
--to=nobozo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).