From: Jon Forrest <nobozo@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] For Real - Fixed pluralization in diff reports
Date: Mon, 01 Aug 2011 11:27:49 -0700 [thread overview]
Message-ID: <4E36F025.9040100@gmail.com> (raw)
In-Reply-To: <20110801180603.GB10636@sigill.intra.peff.net>
On 8/1/2011 11:06 AM, Jeff King wrote:
>
> I think he means that auto-pluralization like this cannot be done in an
> i18n world, as many languages do not simply add "s". Your patch would
> have to use ngettext, something like this (totally untested and just
> copying a similar spot in suggest_reattach, as I have never done any
> i18n myself):
[snip]
> And that gives translators a chance to specify the entire singular and
> plural versions separately.
I entirely agree. My point is only that the various tests
that expect the current behavior will have to be changed
whether the implementation of correct plurals uses my
inferior method or the way more correct i18n method.
Jon
next prev parent reply other threads:[~2011-08-01 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 4:46 [PATCH] For Real - Fixed pluralization in diff reports Jon Forrest
2011-08-01 4:50 ` Nguyen Thai Ngoc Duy
2011-08-01 4:57 ` Jon Forrest
2011-08-01 5:21 ` Nguyen Thai Ngoc Duy
2011-08-01 9:58 ` Sverre Rabbelier
2011-08-01 14:32 ` Jon Forrest
2011-08-01 18:06 ` Jeff King
2011-08-01 18:27 ` Jon Forrest [this message]
2011-08-01 18:32 ` Sverre Rabbelier
2011-08-01 18:38 ` Jeff King
2011-08-03 13:38 ` Jakub Narebski
2011-08-03 16:52 ` Jon Forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E36F025.9040100@gmail.com \
--to=nobozo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).