From: Jon Forrest <nobozo@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] For Real - Fixed pluralization in diff reports
Date: Wed, 03 Aug 2011 09:52:57 -0700 [thread overview]
Message-ID: <4E397CE9.2070500@gmail.com> (raw)
In-Reply-To: <m3livdqh9h.fsf@localhost.localdomain>
On 8/3/2011 6:38 AM, Jakub Narebski wrote:
> Jon Forrest<nobozo@gmail.com> writes:
> Besides, as it was already said, this is an API.
I pretty much only looked at that one file and it
didn't look at quick glance like an API was being
used to internationalize git.
>> If the goal if the i18n effort is also to produce grammatically
>> correct output in all the supported languages then the
>> tests that my patch would break would have to be rewritten
>> anyway.
>
> That's not it.
We can discuss the correct way to implement a change like this
but the fact remains that whatever the implementation, the issue
that Junio raised will remain. That is, what to do about all
the places that presume the old incorrect output.
This problem isn't specific to git. I can easily imagine
other open source projects that face, or will face, this
problem.
Jon
prev parent reply other threads:[~2011-08-03 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 4:46 [PATCH] For Real - Fixed pluralization in diff reports Jon Forrest
2011-08-01 4:50 ` Nguyen Thai Ngoc Duy
2011-08-01 4:57 ` Jon Forrest
2011-08-01 5:21 ` Nguyen Thai Ngoc Duy
2011-08-01 9:58 ` Sverre Rabbelier
2011-08-01 14:32 ` Jon Forrest
2011-08-01 18:06 ` Jeff King
2011-08-01 18:27 ` Jon Forrest
2011-08-01 18:32 ` Sverre Rabbelier
2011-08-01 18:38 ` Jeff King
2011-08-03 13:38 ` Jakub Narebski
2011-08-03 16:52 ` Jon Forrest [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E397CE9.2070500@gmail.com \
--to=nobozo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).