From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: git discussion list <git@vger.kernel.org>
Subject: Re: git diff annoyance / feature request
Date: Fri, 26 Aug 2011 23:16:57 +0200 [thread overview]
Message-ID: <4E580D49.1070006@lsrfire.ath.cx> (raw)
In-Reply-To: <4E569F10.8060808@panasas.com>
Am 25.08.2011 21:14, schrieb Boaz Harrosh:
>
> git diff has this very annoying miss-fixture where it will state
> as hunk header the closest label instead of the function name.
>
> So I get:
> @@ -675,9 +670,23 @@ try_again:
> }
>
> if (flag) {
> - foo();
> + bazz();
> }
>
>
> Instead of what I'd like:
> @@ -563,12 +563,7 @@ static int write_exec(struct page_collect *pcol)
> }
>
> if (flag) {
> - foo();
> + bazz();
> }
Cheap trick: change your coding style to place a single space before
labels instead of having them start right at the beginning of a line.
René
next prev parent reply other threads:[~2011-08-26 21:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 19:14 git diff annoyance / feature request Boaz Harrosh
2011-08-25 20:00 ` Jeff King
2011-08-25 20:40 ` [RFC/PATCH] attr: map builtin userdiff drivers to well-known extensions Jeff King
2011-08-25 21:00 ` Eric Sunshine
2011-08-25 21:06 ` Jeff King
2011-08-25 22:01 ` Boaz Harrosh
2011-08-25 23:44 ` Eric Sunshine
2011-08-26 2:39 ` Jeff King
2011-08-25 22:29 ` Brandon Casey
2011-08-26 2:45 ` Jeff King
2011-08-26 3:58 ` Eric Sunshine
2011-08-26 15:33 ` Brandon Casey
2011-08-25 22:57 ` Junio C Hamano
2011-08-26 2:59 ` Jeff King
2011-08-26 5:52 ` Junio C Hamano
2011-08-26 9:44 ` Thomas Rast
2011-08-27 5:14 ` Alexey Shumkin
2011-08-25 20:27 ` git diff annoyance / feature request Junio C Hamano
2011-08-25 21:58 ` Boaz Harrosh
2011-08-26 9:08 ` Miles Bader
2011-08-26 21:16 ` René Scharfe [this message]
2011-08-26 21:37 ` Boaz Harrosh
2011-08-26 21:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E580D49.1070006@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=bharrosh@panasas.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).