From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Fredrik Kuivinen <frekui@gmail.com>
Cc: David Aguilar <davvid@gmail.com>,
Brian Gernhardt <brian@gernhardtsoftware.com>,
Git List <git@vger.kernel.org>
Subject: Re: obstack fails to compile on OS X 10.7
Date: Thu, 01 Sep 2011 18:30:50 +0100 [thread overview]
Message-ID: <4E5FC14A.8040008@ramsay1.demon.co.uk> (raw)
In-Reply-To: <20110828200846.GA10754@fredrik-Q430-Q530>
Fredrik Kuivinen wrote:
> On Sat, Aug 27, 2011 at 03:14:43AM -0700, David Aguilar wrote:
>> On Sat, Aug 27, 2011 at 02:21:40AM -0400, Brian Gernhardt wrote:
[snip]
>> I suspect that more exotic platforms may have problems
>> with obstack.h as well. This probably needs some testing
>> on SunOS, AIX, IRIX, etc.
Just FYI, my cygwin and mingw builds failed in the same way as OS X ...
> Something like this (tested on Linux and SunOS 5.10):
>
> -- 8< --
>
> Subject: [PATCH RFC] obstack: Fix portability issues
>
> i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1, SunOS 5.10, and possibly
> others do not have exit.h and exitfail.h. Remove the use of these in
> obstack.c.
>
> The __block variable was renamed to block to avoid a gcc error:
>
> compat/obstack.h:190: error: __block attribute can be specified on variables only
>
> Initial-patch-by: David Aguilar <davvid@gmail.com>
> Reported-by: Brian Gernhardt <brian@gernhardtsoftware.com>
> Signed-off-by: Fredrik Kuivinen <frekui@gmail.com>
> ---
... and this fixes the build(s) just fine[1]. Thanks!
ATB,
Ramsay Jones
[1] Well the build is fine on cygwin, but the mingw build fails for
an unrelated reason; compat/obstack.c compiles just fine.
prev parent reply other threads:[~2011-09-01 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-27 6:21 obstack fails to compile on OS X 10.7 Brian Gernhardt
2011-08-27 10:14 ` David Aguilar
2011-08-28 3:57 ` Brian Gernhardt
2011-08-28 20:08 ` Fredrik Kuivinen
2011-08-29 3:18 ` David Aguilar
2011-08-29 6:07 ` Junio C Hamano
2011-09-01 17:30 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5FC14A.8040008@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=brian@gernhardtsoftware.com \
--cc=davvid@gmail.com \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).