From: Johannes Sixt <j.sixt@viscovery.net>
To: Naohiro Aota <naota@elisp.net>
Cc: git@vger.kernel.org, gitster@pobox.com, tarmigan+git@gmail.com
Subject: Re: [PATCH] shell portability: Use sed instead of non-portable variable expansion
Date: Mon, 05 Sep 2011 09:03:30 +0200 [thread overview]
Message-ID: <4E647442.9000005@viscovery.net> (raw)
In-Reply-To: <8762l73758.fsf@elisp.net>
Am 9/5/2011 7:11, schrieb Naohiro Aota:
> Variable expansions like "${foo#bar}" or "${foo%bar}" doesn't work on
> shells like FreeBSD sh and they made the test to fail. This patch
> replace such variable expansions with sed.
>
> Signed-off-by: Naohiro Aota <naota@elisp.net>
> ---
>
> Testing on FreeBSD failed because of this "bash-ism".
These are not bashism, but features require by POSIX.
I'd rather suspect that the failures are not because FreeBSD sh does not
have ${%} or ${#}, but rather that it interprets the meaning of the
backslash in this case in a way different from other shells.
> run_backend() {
> echo "$2" |
> - QUERY_STRING="${1#*\?}" \
> - PATH_TRANSLATED="$HTTPD_DOCUMENT_ROOT_PATH/${1%%\?*}" \
What happens if you write these as
QUERY_STRING=${1#*\?} \
PATH_TRANSLATED=$HTTPD_DOCUMENT_ROOT_PATH/${1%%\?*} \
i.e., drop the double-quotes?
-- Hannes
next prev parent reply other threads:[~2011-09-05 7:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 5:11 [PATCH] shell portability: Use sed instead of non-portable variable expansion Naohiro Aota
2011-09-05 7:03 ` Johannes Sixt [this message]
2011-09-05 7:15 ` Junio C Hamano
2011-09-05 7:35 ` Johannes Sixt
2011-09-05 7:45 ` Junio C Hamano
2011-09-05 8:16 ` Johannes Sixt
2011-09-05 8:21 ` Johannes Sixt
2011-09-05 7:55 ` Naohiro Aota
2011-09-05 7:09 ` Junio C Hamano
2011-09-05 7:54 ` Johannes Sixt
2011-09-05 8:11 ` Junio C Hamano
2011-09-05 8:22 ` Junio C Hamano
2011-09-06 19:09 ` [PATCH] Makefile: abort on shells that do not support ${parameter%word} expansion Brandon Casey
2011-09-06 19:32 ` Brandon Casey
2011-09-06 20:30 ` Brandon Casey
2011-09-06 20:01 ` Junio C Hamano
2011-09-06 20:09 ` Brandon Casey
2011-09-06 20:03 ` Junio C Hamano
2011-09-06 20:20 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E647442.9000005@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=naota@elisp.net \
--cc=tarmigan+git@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).