From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, cmn@elego.de,
A Large Angry SCM <gitzilla@gmail.com>
Subject: Re: [PATCH v2 0/7] Improved infrastructure for refname normalization
Date: Mon, 12 Sep 2011 17:11:30 +0200 [thread overview]
Message-ID: <4E6E2122.8000201@alum.mit.edu> (raw)
In-Reply-To: <7vehzmbd0o.fsf@alter.siamese.dyndns.org>
On 09/12/2011 06:28 AM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> There were a few minor things that looked worth mentioning while
> reviewing, though.
>
> - (style) You seem to be fond of pre-increment a lot, but in general our
> codebase prefers post-increment especially when the end result does not
> make any difference, e.g.
>
> for (i = 1; ...; ++i) {
> ...
OK, changed.
> - (series structure) It might make the series progress easier to follow
> if you introduced check_ref_format_unsafe() in the same commit where
> you change check_ref_format() to take flags parameter.
OK. I'll take the opportunity to rename the functions to
check_refname_format*(), to make it more obvious that they only concern
themselves with the refnames and not the references themselves.
I discovered a bug in my code for handling refnames without
normalization; I will also fix that in v3.
OTOH I am again having serious doubts that trying to support
unnormalized refnames is a good idea. I will write more when I have
time to argue my case.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2011-09-12 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-10 6:50 [PATCH v2 0/7] Improved infrastructure for refname normalization Michael Haggerty
2011-09-10 6:50 ` [PATCH v2 1/7] t1402: add some more tests Michael Haggerty
2011-09-10 6:50 ` [PATCH v2 2/7] Change bad_ref_char() to return a boolean value Michael Haggerty
2011-09-10 6:50 ` [PATCH v2 3/7] git check-ref-format: add options --allow-onelevel and --refspec-pattern Michael Haggerty
2011-09-10 6:50 ` [PATCH v2 4/7] Change check_ref_format() to take a flags argument Michael Haggerty
2011-09-10 6:50 ` [PATCH v2 5/7] Add a library function normalize_refname() Michael Haggerty
2011-09-10 6:50 ` [PATCH v2 6/7] Do not allow ".lock" at the end of any refname component Michael Haggerty
2011-09-10 6:50 ` [PATCH v2 7/7] Add tools to avoid the use of unnormalized refnames Michael Haggerty
2011-09-12 4:28 ` [PATCH v2 0/7] Improved infrastructure for refname normalization Junio C Hamano
2011-09-12 15:11 ` Michael Haggerty [this message]
2011-09-12 16:44 ` Junio C Hamano
2011-09-13 4:16 ` Michael Haggerty
2011-09-13 17:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6E2122.8000201@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitzilla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).