From: Luke Diamand <luke@diamand.org>
To: Pete Wyckoff <pw@padd.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCHv2] git-p4: handle files with shell metacharacters
Date: Fri, 30 Sep 2011 10:06:06 +0100 [thread overview]
Message-ID: <4E85867E.2050805@diamand.org> (raw)
In-Reply-To: <20110927130334.GA24327@arf.padd.com>
On 27/09/11 14:03, Pete Wyckoff wrote:
<snip>
>
> If you don't mind, I'll just queue it up with the utf16 and
> test-refactor stuff I have, and send it all to Junio post-1.7.7.
> Here's how I plan to adjust your tests, given the feedback that
> Junio gave earlier and from reading other tests in t/.
>
> -- Pete
Pete - I've just noticed that t9803 sets P4EDITOR up for the wrong commit.
It works fine for me in my the setup I've got at home but on another
setup hangs trying to run vi from within the test.
It looks like two or possibly three bugs combine with each other.
(a) my misplacement of P4EDITOR
(b) git-p4 doesn't check the return code from system(editor + fileName)
at around 1018, so it just carries blithely on.
(c) "git var GIT_EDITOR" called from within the test harness gives
differing results. In one setup I get "vi", in another, nothing. The
tests pass in the latter case.
I'll submit a new patch series to fix (a) and (b). I'm not sure if (c)
is a bug or a feature. If I get very keen I might also include a tidied
up version of the recent patch for turning off the editor explicitly.
Luke
prev parent reply other threads:[~2011-09-30 9:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 21:29 [PATCH/RFCv1] git-p4: handle files with shell metacharacters Luke Diamand
2011-09-26 21:29 ` Luke Diamand
2011-09-26 21:47 ` Pete Wyckoff
2011-09-27 8:40 ` [RFC/PATCHv2] " Luke Diamand
2011-09-27 8:40 ` Luke Diamand
2011-09-27 9:32 ` Luke Diamand
2011-09-27 13:03 ` Pete Wyckoff
2011-09-30 9:06 ` Luke Diamand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E85867E.2050805@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).