From: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
To: Marcus Karlsson <mk@acc.umu.se>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] gitk: Show patch for initial commit
Date: Sat, 01 Oct 2011 11:54:11 +0200 [thread overview]
Message-ID: <4E86E343.5070704@in.waw.pl> (raw)
In-Reply-To: <20110930215021.GA3005@kennedy.acc.umu.se>
On 09/30/2011 11:50 PM, Marcus Karlsson wrote:
> Make gitk show the patch for the initial commit.
>
> Signed-off-by: Marcus Karlsson<mk@acc.umu.se>
> ---
> gitk-git/gitk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 4cde0c4..20aeae6 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {
> lappend cmd HEAD
> }
> } else {
> - set cmd [concat | git diff-tree -r $flags $ids]
> + set cmd [concat | git diff-tree -r --root $flags $ids]
> }
> return $cmd
> }
Cool, this works for me! But I think I would be really nice if gitk
respected the configuration value of log.showroot. This would give nice
consistency amongst the various tools.
Zbyszek
next prev parent reply other threads:[~2011-10-01 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 21:50 [PATCH] gitk: Show patch for initial commit Marcus Karlsson
2011-10-01 9:54 ` Zbigniew Jędrzejewski-Szmek [this message]
2011-10-01 18:42 ` Marcus Karlsson
2011-10-01 20:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E86E343.5070704@in.waw.pl \
--to=zbyszek@in.waw.pl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mk@acc.umu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).