From: Johannes Sixt <j.sixt@viscovery.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Matt Kraai <kraai@ftbfs.org>,
Gerrit Pape <pape@smarden.org>,
Ian Jackson <ijackson@chiark.greenend.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2] ident: check /etc/mailname if email is unknown
Date: Mon, 03 Oct 2011 09:09:49 +0200 [thread overview]
Message-ID: <4E895FBD.8020904@viscovery.net> (raw)
In-Reply-To: <20111003061633.GB17289@elie>
Am 10/3/2011 8:16, schrieb Jonathan Nieder:
> +static int add_mailname_host(char *buf, size_t len)
> +{
> + FILE *mailname;
> +
> + mailname = fopen("/etc/mailname", "r");
> + if (!mailname) {
> + if (errno != ENOENT)
> + warning("cannot open /etc/mailname: %s",
> + strerror(errno));
This warns on EACCES. Is that OK? (Just asking, I have no opinion.)
-- Hannes
next prev parent reply other threads:[~2011-10-03 7:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 4:57 [PATCH/RFC] ident: check /etc/mailname if email is unknown Jonathan Nieder
2011-10-03 5:30 ` Junio C Hamano
2011-10-03 6:16 ` [PATCH v2] " Jonathan Nieder
2011-10-03 7:09 ` Johannes Sixt [this message]
2011-10-03 7:44 ` Jonathan Nieder
2011-10-03 19:13 ` Junio C Hamano
2011-10-06 17:17 ` [PATCH/RFC jn/ident-from-etc-mailname] ident: do not retrieve default ident when unnecessary Jonathan Nieder
2011-10-06 18:19 ` Junio C Hamano
2011-10-06 18:48 ` Jonathan Nieder
2011-10-03 11:32 ` [PATCH v2] ident: check /etc/mailname if email is unknown Ian Jackson
2011-10-03 19:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E895FBD.8020904@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ijackson@chiark.greenend.org.uk \
--cc=jrnieder@gmail.com \
--cc=kraai@ftbfs.org \
--cc=pape@smarden.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).