From: Michael Haggerty <mhagger@alum.mit.edu>
To: Brandon Casey <drafnel@gmail.com>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
gitster@pobox.com, git@vger.kernel.org, peff@peff.net,
j.sixt@viscovery.net
Subject: Re: [PATCH v3 5/5] attr.c: respect core.ignorecase when matching attribute patterns
Date: Tue, 11 Oct 2011 05:44:40 +0200 [thread overview]
Message-ID: <4E93BBA8.6080403@alum.mit.edu> (raw)
In-Reply-To: <CA+sFfMd9exQcGfTGLJFPXG3-bq-ukn7K4m1R=LvLKqc1-jDVQw@mail.gmail.com>
On 10/10/2011 08:01 PM, Brandon Casey wrote:
> On Sun, Oct 9, 2011 at 10:16 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> Maybe my commit message is not clear that it is describing the current
> behavior and not defining it. Instead of
>
> git should only match the portion of the path below the directory
> holding the .gitignore file according to the setting of
> core.ignorecase.
>
> maybe I should say
>
> git will currently only match the portion of the path...
>
> I could also remove the following test from the CASE_INSENSITIVE_FS
> tests since it is really a dontcare:
>
> attr_check A/b/h a/b/h "-c core.ignorecase=0"
>
> We don't care what happens when the user supplies A/b/h and a/b/h
> exists on disk when core.ignorecase=0, we only care that A/b/h is
> interpreted correctly when core.ignorecase=1.
Sounds good to me.
Thanks,
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2011-10-11 3:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VYN8m1JCy102-eaWWa-bsunEvt3zeXLJkVg7FZKZCtXT-Ww0vg7a8xA7NTvrZTiovKTnJ9Hlom0@cipher.nrlssc.navy.mil>
2011-10-06 18:22 ` [PATCH v3 1/5] attr.c: avoid inappropriate access to strbuf "buf" member Brandon Casey
2011-10-06 18:22 ` [PATCH v3 2/5] cleanup: use internal memory allocation wrapper functions everywhere Brandon Casey
2011-10-06 18:22 ` [PATCH v3 3/5] builtin/mv.c: plug miniscule memory leak Brandon Casey
2011-10-06 18:22 ` [PATCH v3 4/5] attr: read core.attributesfile from git_default_core_config Brandon Casey
2011-10-06 18:22 ` [PATCH v3 5/5] attr.c: respect core.ignorecase when matching attribute patterns Brandon Casey
2011-10-09 15:16 ` Michael Haggerty
2011-10-10 18:01 ` Brandon Casey
2011-10-11 3:44 ` Michael Haggerty [this message]
2011-10-11 15:53 ` [PATCH v4] " Brandon Casey
2011-10-11 16:54 ` Junio C Hamano
2011-10-12 20:18 ` Brandon Casey
2011-10-12 20:24 ` Junio C Hamano
2011-10-11 0:00 ` [PATCH v3 5/5] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E93BBA8.6080403@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).