From: Michael Haggerty <mhagger@alum.mit.edu>
To: Drew Northup <drew.northup@maine.edu>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
Jakub Narebski <jnareb@gmail.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
Johan Herland <johan@herland.net>,
Julian Phillips <julian@quantumfyre.co.uk>
Subject: Re: [PATCH 07/14] is_refname_available(): remove the "quiet" argument
Date: Fri, 14 Oct 2011 07:35:39 +0200 [thread overview]
Message-ID: <4E97CA2B.6080202@alum.mit.edu> (raw)
In-Reply-To: <1318509685.7231.6.camel@drew-northup.unet.maine.edu>
On 10/13/2011 02:41 PM, Drew Northup wrote:
>
> On Thu, 2011-10-13 at 09:58 +0200, mhagger@alum.mit.edu wrote:
>> From: Michael Haggerty <mhagger@alum.mit.edu>
>>
>> quiet was always set to 0, so get rid of it. Add a function docstring
>> for good measure.
>
> I would like to know if perhaps it was an unfinished project somewhere
> to propagate the "quiet" option down to this level before removing the
> function argument. Comments?
The is_refname_available() function, including the quiet option, was
added in c976d415e53 (coincidentally the same commit that added
RENAME-REF). I am unable to find any use of the function with quiet=1
anywhere in history.
>> +/*
>> + * Return true iff a reference named refname could be created without
>
> Did you really mean "iff" (as in "if and only if") or just plain "if"
> here?
I did indeed mean "if and only if". Are you asking because you think
that abbreviation is too obscure, or because you think that "if and only
if" is logically incorrect here and I should have used "if"?
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2011-10-14 5:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 7:58 [PATCH 00/14] Tidying up references code mhagger
2011-10-13 7:58 ` [PATCH 01/14] cache.h: add comments for git_path() and git_path_submodule() mhagger
2011-10-13 18:37 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 02/14] struct ref_list: document name member mhagger
2011-10-13 18:37 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 03/14] refs.c: rename some local "refname" variables mhagger
2011-10-13 7:58 ` [PATCH 04/14] refs: rename some parameters result -> sha1 mhagger
2011-10-13 18:42 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 05/14] clear_ref_list(): rename from free_ref_list() mhagger
2011-10-13 18:43 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 06/14] resolve_gitlink_ref(): improve docstring mhagger
2011-10-13 18:48 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 07/14] is_refname_available(): remove the "quiet" argument mhagger
2011-10-13 12:41 ` Drew Northup
2011-10-13 18:49 ` Junio C Hamano
2011-10-14 5:35 ` Michael Haggerty [this message]
2011-10-13 7:58 ` [PATCH 08/14] parse_ref_line(): add docstring mhagger
2011-10-13 7:58 ` [PATCH 09/14] add_ref(): " mhagger
2011-10-13 7:58 ` [PATCH 10/14] is_dup_ref(): extract function from sort_ref_list() mhagger
2011-10-13 20:43 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 11/14] refs: change signatures of get_packed_refs() and get_loose_refs() mhagger
2011-10-13 7:58 ` [PATCH 12/14] get_ref_dir(): change signature mhagger
2011-10-13 7:58 ` [PATCH 13/14] Pass a (cached_refs *) to the resolve_gitlink_*() functions mhagger
2011-10-13 7:58 ` [PATCH 14/14] resolve_gitlink_ref_recursive(): change to work with struct cached_refs mhagger
2011-10-13 8:06 ` [PATCH] t1402-check-ref-format: skip tests of refs beginning with slash on Windows Johannes Sixt
2011-10-13 23:00 ` Junio C Hamano
2011-10-13 23:07 ` Junio C Hamano
2011-10-14 6:40 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E97CA2B.6080202@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=drew.northup@maine.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jnareb@gmail.com \
--cc=johan@herland.net \
--cc=julian@quantumfyre.co.uk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).